Upgrade to 0.0.3, correct for codeql-util breaking dense rank change. #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous publication didn't properly test modules with the latest codeql/util, thus missing a breaking change to `DenseRank` that affected some modules. Publish a fix to this as 0.0.3 -- fixes the codeql/util constraint, and adapts modules to the new `DenseRank` API.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the qtil library to version 0.0.3 to address a breaking change in the CodeQL util library's DenseRank API. The changes adapt the codebase to use the new DenseRank1 module instead of DenseRank2 and update the API usage pattern throughout the modules.
Key changes:
- Updates the
DenseRankAPI usage inCondensedList.qllto useDenseRank1instead ofDenseRank2 - Upgrades all package versions to 0.0.3 and updates dependency constraints
- Updates all CodeQL dependency lock files to use newer versions compatible with the breaking change
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/qtil/list/CondensedList.qll | Adapts DenseRank API usage to new DenseRank1 module and corrects API call patterns |
| src/qlpack.yml | Updates main package version to 0.0.3 and constrains codeql/util dependency to >2.0.0 |
| test/qtil/list/CondensedListTest.ql | Fixes minor syntax error in test failure message |
| Multiple language-specific qlpack.yml files | Updates package versions to 0.0.3 and dependency references |
| Multiple codeql-pack.lock.yml files | Updates dependency versions to support new CodeQL util API |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
In the future, we should consider matrix tests to ensure we're compatible with the ranges that we declare -- both in package versions, and against various CLI versions. For the meantime, the best approach is to test the oldest versions, and assume forward compatibility. At least, that's what's best for codeql/util, if not for the language packs where our support spans multiple major revisions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous publication didn't properly test modules with the latest codeql/util, thus missing a breaking change to
DenseRankthat affected some modules.Publish a fix to this as 0.0.3 -- fixes the codeql/util constraint, and adapts modules to the new
DenseRankAPI.