_begun isn't needed; it is only set, never read

eringerli · eringerli · commit 91f8940c6a9d · 2022-05-14T16:11:22.000+02:00
diff --git a/Adafruit_SPIDevice.cpp b/Adafruit_SPIDevice.cpp
@@ -20,7 +20,6 @@ Adafruit_SPIDevice::Adafruit_SPIDevice(int8_t cspin, uint32_t freq,
   _cs = cspin;
   _sck = _mosi = _miso = -1;
   _spi = theSPI;
-  _begun = false;
   _spiSetting = new SPISettings(freq, dataOrder, dataMode);
   _freq = freq;
   _dataOrder = dataOrder;
@@ -67,7 +66,6 @@ Adafruit_SPIDevice::Adafruit_SPIDevice(int8_t cspin, int8_t sckpin,
   _freq = freq;
   _dataOrder = dataOrder;
   _dataMode = dataMode;
-  _begun = false;
   _spiSetting = new SPISettings(freq, dataOrder, dataMode);
   _spi = nullptr;
 }
@@ -109,7 +107,6 @@ bool Adafruit_SPIDevice::begin(void) {
     }
   }
 
-  _begun = true;
   return true;
 }
 
diff --git a/Adafruit_SPIDevice.h b/Adafruit_SPIDevice.h
@@ -116,7 +116,6 @@ class Adafruit_SPIDevice {
   BusIO_PortReg *mosiPort, *clkPort, *misoPort, *csPort;
   BusIO_PortMask mosiPinMask, misoPinMask, clkPinMask, csPinMask;
 #endif
-  bool _begun;
 };
 
 #endif // has SPI defined

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,6 @@ Adafruit_SPIDevice::Adafruit_SPIDevice(int8_t cspin, uint32_t freq,`
`20`	`20`	`_cs = cspin;`
`21`	`21`	`_sck = _mosi = _miso = -1;`
`22`	`22`	`_spi = theSPI;`
`23`		`- _begun = false;`
`24`	`23`	`_spiSetting = new SPISettings(freq, dataOrder, dataMode);`
`25`	`24`	`_freq = freq;`
`26`	`25`	`_dataOrder = dataOrder;`
`@@ -67,7 +66,6 @@ Adafruit_SPIDevice::Adafruit_SPIDevice(int8_t cspin, int8_t sckpin,`
`67`	`66`	`_freq = freq;`
`68`	`67`	`_dataOrder = dataOrder;`
`69`	`68`	`_dataMode = dataMode;`
`70`		`- _begun = false;`
`71`	`69`	`_spiSetting = new SPISettings(freq, dataOrder, dataMode);`
`72`	`70`	`_spi = nullptr;`
`73`	`71`	`}`
`@@ -109,7 +107,6 @@ bool Adafruit_SPIDevice::begin(void) {`
`109`	`107`	`}`
`110`	`108`	`}`
`111`	`109`
`112`		`- _begun = true;`
`113`	`110`	`return true;`
`114`	`111`	`}`
`115`	`112`