Skip to content

ACRL-439 // chore: remove unused workspace dependencies#248

Merged
ogorman89 merged 2 commits into
mainfrom
ian/machete
May 19, 2026
Merged

ACRL-439 // chore: remove unused workspace dependencies#248
ogorman89 merged 2 commits into
mainfrom
ian/machete

Conversation

@ogorman89
Copy link
Copy Markdown
Contributor

@ogorman89 ogorman89 commented May 19, 2026

Description and Rationale

How

  • identified unused workplace dependencies
  • remove them
  • ran test suite

Test Steps

  • automated testing

Other Notes

  • There are some tools that we could add to pre-commit that check for unused workspace dependencies like (cargo-machete)[https://github.com/bnjbvr/cargo-machete] but we have some false positives that we would need to ignore which adds a small amount of clutter to the manifests.

  • [ ✅ ] I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.

@ogorman89 ogorman89 self-assigned this May 19, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.37%. Comparing base (ea9a266) to head (cb53315).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   78.42%   78.37%   -0.06%     
==========================================
  Files          62       62              
  Lines        3852     3852              
==========================================
- Hits         3021     3019       -2     
- Misses        831      833       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ogorman89 ogorman89 requested a review from drmorr0 May 19, 2026 17:11
Copy link
Copy Markdown
Contributor

@drmorr0 drmorr0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I think it could be nice to put this as a pre-commit hook, but if it's an enormous pain or there are too many false positives we can leave it out.

@ogorman89
Copy link
Copy Markdown
Contributor Author

lgtm! I think it could be nice to put this as a pre-commit hook, but if it's an enormous pain or there are too many false positives we can leave it out.

Hook added, a few ignores added.

@ogorman89 ogorman89 merged commit 05ae6be into main May 19, 2026
7 checks passed
@ogorman89 ogorman89 deleted the ian/machete branch May 19, 2026 19:32
@ogorman89 ogorman89 changed the title chore: remove unused workspace dependencies SK-438 // chore: remove unused workspace dependencies May 19, 2026
@ogorman89 ogorman89 changed the title SK-438 // chore: remove unused workspace dependencies ACRL-438 // chore: remove unused workspace dependencies May 19, 2026
@linear
Copy link
Copy Markdown

linear Bot commented May 19, 2026

ACRL-438

ACRL-439

@ogorman89 ogorman89 changed the title ACRL-438 // chore: remove unused workspace dependencies ACRL-439 // chore: remove unused workspace dependencies May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants