sk-245 // make SKEL its own crate#247
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
=======================================
Coverage 78.37% 78.37%
=======================================
Files 62 62
Lines 3852 3852
=======================================
Hits 3019 3019
Misses 833 833 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
drmorr0
approved these changes
May 19, 2026
| sk-skel = { workspace = true } | ||
| tokio = { workspace = true } | ||
| blackbox-metrics = "0.0.1" | ||
| blackbox-metrics = { workspace = true } |
|
|
||
| [dependencies] | ||
| anyhow = { workspace = true } | ||
| assertables = { workspace = true } |
Contributor
There was a problem hiding this comment.
assertables should be a dev dependency, I think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Rationale
How
sk-skelapply_skel_file,process_traceand themetric_namesconstsTest Steps
Other Notes
N/A
[ ✅ ] I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.