test: cover internal VST3 removal cleanup

Author: ChuxiJ

src/store/__tests__/vst3Store.test.ts

@@ -174,6 +174,18 @@ describe('vst3Store', () => {
       removePluginSpy.mockRestore();
     });
 
+    it('_removeInstance also removes the live plugin for bridge callback paths', () => {
+      const removePluginSpy = vi.spyOn(pluginEngine, 'removePlugin').mockImplementation(() => undefined);
+      useVST3Store.getState()._upsertInstance(mockInstance());
+
+      useVST3Store.getState()._removeInstance('inst-1');
+
+      expect(removePluginSpy).toHaveBeenCalledWith('track-1', 'inst-1');
+      expect(useVST3Store.getState().instances['inst-1']).toBeUndefined();
+
+      removePluginSpy.mockRestore();
+    });
+
     it('removing non-existent instance is a no-op', () => {
       const removePluginSpy = vi.spyOn(pluginEngine, 'removePlugin').mockImplementation(() => undefined);
       useVST3Store.getState()._upsertInstance(mockInstance());

src/store/vst3Store.ts

@@ -234,15 +234,6 @@ export const useVST3Store = create<VST3Store>()((set, get) => ({
   },
 
   removeInstance: (instanceId: string) => {
-    const inst = get().instances[instanceId];
-    if (!inst) return;
-
-    try {
-      pluginEngine.removePlugin(inst.trackId, instanceId);
-    } catch {
-      // Store removal should still succeed if the live audio chain is already gone.
-    }
-
     get()._removeInstance(instanceId);
   },
 
@@ -411,6 +402,12 @@ export const useVST3Store = create<VST3Store>()((set, get) => ({
       return;
     }
 
+    try {
+      pluginEngine.removePlugin(inst.trackId, instanceId);
+    } catch {
+      // Store removal should still succeed if the live audio chain is already gone.
+    }
+
     const order = (pluginOrder[inst.trackId] ?? []).filter((id) => id !== instanceId);
     set({
       instances: next,