Skip to content

Commit 109633c

Browse files
committed
drop kagglesdk shim, keep auth fix only
Per maintainer feedback on Kaggle#1082.
1 parent b4f4d2f commit 109633c

4 files changed

Lines changed: 0 additions & 71 deletions

File tree

‎src/kaggle/__init__.py‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
# coding=utf-8
22
from __future__ import absolute_import
3-
4-
import kaggle.kagglesdk_compat # noqa: F401 — apply kagglesdk compatibility patches
5-
63
from kaggle.api.kaggle_api_extended import KaggleApi
74

85
__version__ = "2.2.3"

‎src/kaggle/kagglesdk_compat.py‎

Lines changed: 0 additions & 26 deletions
This file was deleted.
Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,13 @@
11
# coding=utf-8
22
import sys
33
import unittest
4-
from datetime import timedelta
54
from unittest.mock import patch
65

76
sys.path.insert(0, "../../src")
87

9-
from kagglesdk.kaggle_object import TimeDeltaSerializer
10-
from kagglesdk.kernels.types.kernels_api_service import ApiGetAcceleratorQuotaStatisticsResponse
11-
128
from kaggle.api.kaggle_api_extended import KaggleApi
139

1410

15-
class TestTimeDeltaSerializerCompat(unittest.TestCase):
16-
"""Tests for the kagglesdk TimeDeltaSerializer compatibility patch."""
17-
18-
def test_whole_second_duration(self):
19-
self.assertEqual(TimeDeltaSerializer._from_dict_value("0s"), timedelta(0))
20-
self.assertEqual(TimeDeltaSerializer._from_dict_value("151s"), timedelta(seconds=151))
21-
22-
def test_fractional_second_duration(self):
23-
self.assertEqual(
24-
TimeDeltaSerializer._from_dict_value("151.500s"),
25-
timedelta(seconds=151, microseconds=500000),
26-
)
27-
28-
def test_quota_response_deserializes_whole_second_durations(self):
29-
response = ApiGetAcceleratorQuotaStatisticsResponse.from_json(
30-
'{"gpuQuota":{"timeUsed":"0s","totalTimeAllowed":"151s"}}'
31-
)
32-
self.assertEqual(response.gpu_quota.time_used, timedelta(0))
33-
self.assertEqual(response.gpu_quota.total_time_allowed, timedelta(seconds=151))
34-
35-
3611
class TestHelpOrVersionAuth(unittest.TestCase):
3712
"""Tests for help/version detection used during authenticate()."""
3813

‎tests/unit/test_quota.py‎

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77

88
sys.path.insert(0, "../..")
99

10-
from kagglesdk.kernels.types.kernels_api_service import ApiGetAcceleratorQuotaStatisticsResponse
11-
1210
from kaggle.api.kaggle_api_extended import KaggleApi
1311

1412

@@ -33,21 +31,6 @@ class TestQuota(unittest.TestCase):
3331
def setUp(self):
3432
self.api = KaggleApi.__new__(KaggleApi)
3533

36-
@patch.object(KaggleApi, "build_kaggle_client")
37-
def test_quota_view_whole_second_durations(self, mock_client):
38-
expected = ApiGetAcceleratorQuotaStatisticsResponse.from_json(
39-
'{"gpuQuota":{"timeUsed":"0s","totalTimeAllowed":"30s"}}'
40-
)
41-
mock_kaggle = MagicMock()
42-
mock_kaggle.kernels.kernels_api_client.get_accelerator_quota_statistics.return_value = expected
43-
mock_client.return_value.__enter__ = MagicMock(return_value=mock_kaggle)
44-
mock_client.return_value.__exit__ = MagicMock(return_value=False)
45-
46-
result = self.api.quota_view()
47-
48-
self.assertEqual(result.gpu_quota.time_used, timedelta(0))
49-
self.assertEqual(result.gpu_quota.total_time_allowed, timedelta(seconds=30))
50-
5134
@patch.object(KaggleApi, "build_kaggle_client")
5235
def test_quota_view_returns_response(self, mock_client):
5336
expected = _build_response(gpu=_mock_quota(5, 30), tpu=_mock_quota(0, 20))

0 commit comments

Comments
 (0)