fix getURL function (loophole fixed)

Author: Zone-Infinity

src/main/java/me/isoham/imageframe/mde/config/MessageConfig.java

@@ -51,6 +51,11 @@ public enum Message {
         URL_NOT_WHITELISTED(
                 "messages.moderation.not_whitelisted",
                 "&cYour url type isn't whitelisted. Use a discord url."
+        ),
+
+        INVALID_USAGE(
+                "messages.request.invalid_usage",
+                "&cInvalid Usage"
         );
 
         public final String path;

src/main/java/me/isoham/imageframe/mde/listeners/CommandInterceptor.java

@@ -55,8 +55,10 @@ public void onCommand(PlayerCommandPreprocessEvent event) {
             return;
         }
 
-        String url = getUrl(args);
+        String url = getURL(args);
         if (url == null) {
+            event.setCancelled(true);
+            player.sendMessage(config.getMessages().get(MessageConfig.Message.INVALID_USAGE));
             return;
         }
 
@@ -137,35 +139,32 @@ public void onCommand(PlayerCommandPreprocessEvent event) {
         }
     }
 
-    private static @Nullable String getUrl(String[] args) {
-        String sub = args[1].toLowerCase();
+    // Gets the url and also validates command partially
+    private static @Nullable String getURL(String[] args) {
+        if (args.length < 4) {
+            return null;
+        }
 
-        String url = null;
+        String sub = args[1].toLowerCase();
 
-        switch (sub) {
+        return switch (sub) {
             case "create" -> {
-                if (args.length == 6 || args.length == 7) {
-                    url = args[3];
-                } else if (args.length == 5 && args[4].equalsIgnoreCase("selection")) {
-                    url = args[3];
+                // /imageframe create <name> <url> selection
+                if (args.length == 5 && args[4].equalsIgnoreCase("selection")) {
+                    yield args[3];
                 }
-            }
 
-            case "overlay" -> {
-                if (args.length == 4) {
-                    url = args[3];
-                } else if (args.length == 5 && args[4].equalsIgnoreCase("selection")) {
-                    url = args[3];
+                // /imageframe create <name> <url> <width> <height> [options]
+                if (args.length >= 6) {
+                    yield args[3];
                 }
-            }
 
-            case "refresh" -> {
-                if (args.length >= 4) {
-                    url = args[3];
-                }
+                yield null;
             }
-        }
-        return url;
+
+            case "overlay", "refresh" -> args[3];
+            default -> null;
+        };
     }
 
     private String hash(String input) {