fix: Add windows support

[zhxiaoyu]

1. Use commands through cmd.exe /C in Windows to ensures environment variables are loaded automatically
2. Explicitly specify bash as shell for all runner because powershell doesn't support the && operator
3. Handle the difference between "\n" and "\r\n" on Linux and Windows
4. Handle the difference between path symbols on Linux and Windows

[Wulf]

@zhxiaoyu thank you very much for this. I'd like to ask you one last thing before we merge this in:

Does this solution work on windows?

• https://github.com/Wulf/create-rust-app/blob/65c7500618e796340fdf805095a7c04866df2910/crates/create-rust-app_cli/template/.cargo/bin/frontend.rs#L4

If so, I think it can also help us avoid any required path.resolve(__dirname, ...) for end-users in their vite config files. If not, I guess we'll have to document this caveat for windows users.

[zhxiaoyu]

@zhxiaoyu thank you very much for this. I'd like to ask you one last thing before we merge this in:

Does this solution work on windows?

• https://github.com/Wulf/create-rust-app/blob/65c7500618e796340fdf805095a7c04866df2910/crates/create-rust-app_cli/template/.cargo/bin/frontend.rs#L4

If so, I think it can also help us avoid any required path.resolve(__dirname, ...) for end-users in their vite config files. If not, I guess we'll have to document this caveat for windows users.

Hi @Wulf , this works on windows by my test.

[thespooler]

Is there any plan to release this or does it need more work?

[Wulf]

Hey @thespooler,

It looks good to me, I was just hoping we could attempt something like this from the link above:

#[cfg(windows)]
pub const NPM: &'static str = "npm.cmd";

#[cfg(not(windows))]
pub const NPM: &'static str = "npm";

It’ll make the code much easier to read and maintain instead of having to branch so much. If someone can test this, it would be wonderful, especially for future devs jumping into the codebase. Otherwise, I might have to merge this in as-is.

Moreover:

it can also help us avoid any required path.resolve(__dirname, ...) for end-users in their vite config files. If not, I guess we'll have to document this caveat for windows users.

[zhxiaoyu]

Hey @thespooler,

It looks good to me, I was just hoping we could attempt something like this from the link above:

#[cfg(windows)]
pub const NPM: &'static str = "npm.cmd";

#[cfg(not(windows))]
pub const NPM: &'static str = "npm";

It’ll make the code much easier to read and maintain instead of having to branch so much. If someone can test this, it would be wonderful, especially for future devs jumping into the codebase. Otherwise, I might have to merge this in as-is.

Moreover:

it can also help us avoid any required path.resolve(__dirname, ...) for end-users in their vite config files. If not, I guess we'll have to document this caveat for windows users.

Hi @Wulf , I have modified it as this method.

[thespooler]

I did try @zhxiaoyu branch and it does work on Windows, no issues. cargo test seems to fail for me tho.

[zhxiaoyu]

I did try @zhxiaoyu branch and it does work on Windows, no issues. cargo test seems to fail for me tho.

Hi @thespooler , could you provide the detailed error information?

[thespooler]

It fails on normal_usage_test.

running 1 test
test test ... FAILED

failures:

---- test stdout ----

thread 'test' panicked at crates\vite-rs\tests\normal_usage_test.rs:82:9:
assertion `left == right` failed
  left: 491
 right: 489
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    test

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.09s

[zhxiaoyu]

Have you installed npm packages for examples & tests like this?

(cd ./crates/vite-rs/test_projects && npm ci)
(cd ./crates/vite-rs-axum-0-8/test_projects/basic_usage_test/app && npm ci)
(cd ./crates/vite-rs-axum-0-8/test_projects/ctrl_c_handling_test/app && npm ci)
(cd ./crates/vite-rs-axum-0-8/examples/basic_usage/app && npm ci)
(cd ./crates/vite-rs/examples/vite-project-folder && npm ci)

[thespooler]

You got it... All good now, ✅ all tests pass.