From 125df86cbb3eab1c293b6756116fba6717072721 Mon Sep 17 00:00:00 2001 From: Jonathan Bossenger Date: Thu, 4 Apr 2024 08:23:18 +0200 Subject: [PATCH 1/3] Remove the Sensei module restriction for editors --- wp-content/plugins/wporg-learn/inc/sensei.php | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/wp-content/plugins/wporg-learn/inc/sensei.php b/wp-content/plugins/wporg-learn/inc/sensei.php index 348ba6ec0..5326692fa 100644 --- a/wp-content/plugins/wporg-learn/inc/sensei.php +++ b/wp-content/plugins/wporg-learn/inc/sensei.php @@ -17,6 +17,20 @@ add_action( 'sensei_before_main_content', __NAMESPACE__ . '\theme_wrapper_start' ); add_action( 'sensei_after_main_content', __NAMESPACE__ . '\theme_wrapper_end' ); add_action( 'init', __NAMESPACE__ . '\wporg_correct_sensei_slugs' ); +add_action( 'plugins_loaded', __NAMESPACE__ . '\wporg_correct_sensei_editor_permissions' ); + +/** + * Remove Sensei's default module editor permissions. + * See https://github.com/WordPress/Learn/issues/2331 + * + * @return void + */ +function wporg_correct_sensei_editor_permissions() { + if ( current_user_can( 'editor' ) ) { + remove_filter( 'get_terms', [ Sensei()->modules, 'filter_module_terms' ], 20, 3 ); + remove_filter( 'get_object_terms', [ Sensei()->modules, 'filter_course_selected_terms' ], 20, 3 ); + } +} /** * Slugs in Sensei are translatable, which won't work for our site and the language switcher. From f9362133dab8146ff6c494f69429d330a95d22c9 Mon Sep 17 00:00:00 2001 From: Jonathan Bossenger Date: Thu, 4 Apr 2024 08:34:25 +0200 Subject: [PATCH 2/3] Fixed linting errors --- .wp-env.json | 1 + wp-content/plugins/wporg-learn/inc/sensei.php | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.wp-env.json b/.wp-env.json index 36d90c75a..0ceeed243 100644 --- a/.wp-env.json +++ b/.wp-env.json @@ -1,6 +1,7 @@ { "config": { "WP_DEBUG": true, + "WP_DEBUG_DISPLAY": false, "SCRIPT_DEBUG": true, "WP_DEBUG_LOG": "/tmp/wp-errors.log", "FS_METHOD": "direct", diff --git a/wp-content/plugins/wporg-learn/inc/sensei.php b/wp-content/plugins/wporg-learn/inc/sensei.php index 5326692fa..f460695ef 100644 --- a/wp-content/plugins/wporg-learn/inc/sensei.php +++ b/wp-content/plugins/wporg-learn/inc/sensei.php @@ -27,8 +27,8 @@ */ function wporg_correct_sensei_editor_permissions() { if ( current_user_can( 'editor' ) ) { - remove_filter( 'get_terms', [ Sensei()->modules, 'filter_module_terms' ], 20, 3 ); - remove_filter( 'get_object_terms', [ Sensei()->modules, 'filter_course_selected_terms' ], 20, 3 ); + remove_filter( 'get_terms', array( Sensei()->modules, 'filter_module_terms' ), 20, 3 ); + remove_filter( 'get_object_terms', array( Sensei()->modules, 'filter_course_selected_terms' ), 20, 3 ); } } From 37e36af8351a5f480137435c4d7767f008c1b801 Mon Sep 17 00:00:00 2001 From: Jonathan Bossenger Date: Mon, 29 Apr 2024 17:04:20 +0200 Subject: [PATCH 3/3] Changed action hook --- wp-content/plugins/wporg-learn/inc/sensei.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wp-content/plugins/wporg-learn/inc/sensei.php b/wp-content/plugins/wporg-learn/inc/sensei.php index f460695ef..86453db81 100644 --- a/wp-content/plugins/wporg-learn/inc/sensei.php +++ b/wp-content/plugins/wporg-learn/inc/sensei.php @@ -17,7 +17,7 @@ add_action( 'sensei_before_main_content', __NAMESPACE__ . '\theme_wrapper_start' ); add_action( 'sensei_after_main_content', __NAMESPACE__ . '\theme_wrapper_end' ); add_action( 'init', __NAMESPACE__ . '\wporg_correct_sensei_slugs' ); -add_action( 'plugins_loaded', __NAMESPACE__ . '\wporg_correct_sensei_editor_permissions' ); +add_action( 'init', __NAMESPACE__ . '\wporg_correct_sensei_editor_permissions' ); /** * Remove Sensei's default module editor permissions.