diff --git a/docs/identifier-ui.md b/docs/identifier-ui.md index d840ff51..15191a64 100644 --- a/docs/identifier-ui.md +++ b/docs/identifier-ui.md @@ -73,7 +73,6 @@ The desktop table columns are: - Name - AID -- Current Key - Type - KIDX - PIDX @@ -81,7 +80,7 @@ The desktop table columns are: Mobile cards mirror the same core fields and rotate action. -The AID and current-key display contract: +The AID display contract: - use `truncateMiddle(aid)` as first eight characters, `...`, last eight characters for long values, @@ -90,6 +89,10 @@ The AID and current-key display contract: - stop click propagation so copying does not open details, - use the shared `--app-mono-font` CSS variable. +Do not add Current Key back to the table unless the list API can supply it +without per-row `get(...)` hydration. Current key belongs in details so the +identifier list does not grow an N+1 request pattern. + The table rotate button: - uses the rotate icon, diff --git a/src/features/identifiers/IdentifierTable.tsx b/src/features/identifiers/IdentifierTable.tsx index cd7c096a..8b51c68e 100644 --- a/src/features/identifiers/IdentifierTable.tsx +++ b/src/features/identifiers/IdentifierTable.tsx @@ -20,8 +20,6 @@ import RotateRightIcon from '@mui/icons-material/RotateRight'; import type { IdentifierSummary } from './identifierTypes'; import { formatIdentifierMetadata, - identifierCurrentKey, - identifierUnavailableValue, identifierIdentifierIndex, identifierKeyIndex, identifierType, @@ -48,7 +46,6 @@ interface CopyableMonoValueProps { label: string; copied: boolean; onCopy: (value: string) => void; - color?: string; } const CopyableMonoValue = ({ @@ -56,7 +53,6 @@ const CopyableMonoValue = ({ label, copied, onCopy, - color = 'primary.main', }: CopyableMonoValueProps) => ( ); -const MonospaceUnavailable = () => ( - - {identifierUnavailableValue} - -); - /** * Pure identifier list table. * @@ -157,32 +142,6 @@ export const IdentifierTable = ({ onCopy={copyValue} /> - - - Current Key - - {identifierCurrentKey(identifier) === null ? ( - - ) : ( - - )} - - +
Name AID - Current Key Type KIDX PIDX @@ -270,26 +228,6 @@ export const IdentifierTable = ({ onCopy={copyValue} /> - - {identifierCurrentKey(identifier) === null ? ( - - ) : ( - - )} - {identifierType(identifier)} diff --git a/tests/browser-smoke.mjs b/tests/browser-smoke.mjs index c2320f47..5c6a405b 100644 --- a/tests/browser-smoke.mjs +++ b/tests/browser-smoke.mjs @@ -116,7 +116,7 @@ try { timeout: 10000, }); const identifierTableText = await textContent(page, '[data-testid="identifier-table"]'); - for (const expectedHeader of ['AID', 'Current Key', 'KIDX', 'PIDX', 'Actions']) { + for (const expectedHeader of ['AID', 'KIDX', 'PIDX', 'Actions']) { if (!identifierTableText.includes(expectedHeader)) { throw new Error(`Identifier table is missing ${expectedHeader} header`); }