Skip to content

Increase timeout values for Aethel integration test workflow #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colleenpridemore merged 2 commits into from
Jan 24, 2026
Merged

Increase timeout values for Aethel integration test workflow #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44ee55b
Initial plan
Copilot Jan 15, 2026
149b4fc
Fix timeout issues in Aethel integration test workflow
Copilot Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/aethel-integration-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
echo "ASI_ONE_API_KEY=${{ secrets.ASI_ONE_API_KEY }}" > .env
echo "ASI_ONE_MODEL=asi1-fast" >> .env
echo "ASI_ONE_MAX_TOKENS=500" >> .env
echo "ASI_ONE_TIMEOUT=60000" >> .env
echo "ASI_ONE_TIMEOUT=120000" >> .env

- name: Verify .env file created
working-directory: ./agents
Expand All @@ -53,7 +53,7 @@ jobs:
- name: Run Aethel integration example
working-directory: ./agents
run: npm run example:aethel
timeout-minutes: 5
timeout-minutes: 10

- name: Report success
if: success()
Expand Down
2 changes: 1 addition & 1 deletion agents/communication/CommunicationProtocol.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export class CommunicationProtocol extends EventEmitter {
// Configuration
this.config = {
maxQueueSize: config.maxQueueSize || 100,
messageTimeout: config.messageTimeout || 30000, // 30 seconds
messageTimeout: config.messageTimeout || 120000, // 120 seconds (2 minutes)
rateLimitPerMinute: config.rateLimitPerMinute || 100,
enableEncryption: config.enableEncryption || false,
...config
Comment on lines 75 to 79
Copy link

Copilot AI Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increasing the default messageTimeout to 120s amplifies a resource issue in _waitForResponse: each REQUEST creates a setTimeout that is never cleared when a response arrives, so the timer stays scheduled until it fires (even though it no-ops). Consider storing the timer handle alongside the pending resolve/reject and calling clearTimeout when the response is received (and also on shutdown) to avoid unnecessary queued timers and wakeups under load.

Copilot uses AI. Check for mistakes.
Expand Down
2 changes: 1 addition & 1 deletion agents/examples/aethel-integration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ async function main() {
},
protocol: {
rateLimitPerMinute: 50,
messageTimeout: 10000
messageTimeout: 120000
}
Comment on lines 28 to 31
Copy link

Copilot AI Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow writes ASI_ONE_TIMEOUT into .env, but this example never passes aethelConfig.timeout into new AethelAgent(...), so API requests will still use AethelAgent’s internal default (30s). To make the increased API timeout effective, wire the value through (e.g., include timeout: aethelConfig.timeout in the agent constructor config) or remove the .env timeout if it’s intentionally unused.

Copilot uses AI. Check for mistakes.
});
console.log('✓ Framework initialized\n');
Expand Down
Loading