Commit 73e2350
authored
docs(site): stop three files calling a revert a rollback (#215)
Reverting the commit that added the Worker route reads like the undo
button and is the opposite of one. GitHub Pages used to sit behind that
route and was disabled and its sources deleted when the Astro site went
live, so removing the Worker now leaves the DNS record pointing at
nothing. That is an outage. docs/SITE.md has said so since the cutover,
in a paragraph three below the one telling you to revert.
Three files carried the old advice and none of them carried the
correction:
- site/wrangler.jsonc opened with "Rollback is reverting the commit that
added this block", which is the first thing anyone reads when they go
looking for the route under pressure.
- .github/workflows/site-deploy.yml explained its own no-branch-trigger
design as "what makes reverting a commit a complete rollback".
- docs/SITE.md led the section with a bolded "Rolling back is git revert
of the commit that added the route", then contradicted it further
down. A reader skimming for the bold line got the dangerous half.
All three now say the same thing: fix a bad deploy by rolling site/
forward. The distinction that was missing everywhere is drawn
explicitly -- reverting an ordinary site/ commit is fine and is just
another way of rolling forward, because the deploy publishes whatever
main holds; it is reverting the route itself that has nothing to land
on. Deleting the route in the Cloudflare dashboard is still not a
rollback either, and all three still say that, because the weekly
scheduled deploy re-applies whatever wrangler.jsonc holds.
Comments only. No behaviour changes and no deploy is triggered by this
commit: it touches no file under site/ that the build reads, and the
workflow edit is a comment above the trigger block.
Verified: wrangler.jsonc still parses as JSONC with workers_dev false
and the route unchanged, site-deploy.yml still parses as YAML with both
jobs intact, and the site build, contrast gate, docs validator, 1333
backend tests, scripts/check.py and git diff --check all pass.
Separately confirmed live rather than assumed: www.nojoin.co.uk serves
the merged nav, and /docs/TELEMETRY, /docs/README and /docs/MCP each
still return 301 to their GitHub blob URL. That contract only runs on a
real deployment, so it cannot be checked any other way.1 parent 4f0fa08 commit 73e2350
3 files changed
Lines changed: 25 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
8 | 14 | | |
9 | 15 | | |
10 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
452 | 452 | | |
453 | 453 | | |
454 | 454 | | |
455 | | - | |
456 | | - | |
457 | | - | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
458 | 465 | | |
459 | 466 | | |
460 | 467 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
15 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
16 | 21 | | |
17 | 22 | | |
18 | 23 | | |
| |||
0 commit comments