ci: make the Android gate pass what it actually checks

Three things the gate caught that local runs had not:

`dart format` walks into mobile/build and dies on Gradle's intermediates,
so the CI step now names lib, test and packages explicitly rather than `.`.
It has no ignore file of its own.

Reformatting broke two suppressions. `// ignore: deprecated_member_use`
attaches to the following line, and the formatter reflowed
`import ... show CorePalette;` across four lines, leaving the comment
pointing at nothing. Importing material_color_utilities without a `show`
clause removes the deprecated-member reference from the import site
entirely; the per-usage ignores were already correct and still apply.
CorePalette stays because it is what dynamic_color returns on Android.

A brace-less `if` body in the v2ray-plugin branch of the shadowsocks
converter tripped curly_braces_in_flow_control_structures under
--fatal-infos.

Verified locally with the exact CI command set: dart format clean,
flutter analyze --fatal-infos clean, 731 + 145 + 100 tests, APK builds.

Author: UndergroundAlzar

.github/workflows/android.yml

@@ -125,7 +125,9 @@ jobs:
 
       - name: Check formatting
         working-directory: mobile
-        run: dart format --output=none --set-exit-if-changed .
+        # Explicit source roots, not `.`: dart format has no ignore file and walks into
+        # build/ and .dart_tool/, where it trips over Gradle's intermediates.
+        run: dart format --output=none --set-exit-if-changed lib test packages
 
       - name: Analyse
         working-directory: mobile

mobile/lib/features/connections/connection_detail_sheet.dart

@@ -107,7 +107,8 @@ class ConnectionDetailSheet extends ConsumerWidget {
                 ),
                 ConnectionDetailRow(
                   label: l10n.t('connections.detail.establishTime'),
-                  value: '${formatTimestamp(connection.start)}  '
+                  value:
+                      '${formatTimestamp(connection.start)}  '
                       '(${formatElapsedClock(DateTime.now().difference(connection.start))})',
                 ),
                 if (fields.rule.isNotEmpty)
@@ -244,11 +245,8 @@ class ConnectionDetailRow extends StatelessWidget {
           ? PopupMenuButton<String>(
               tooltip: l10n.t('connections.detail.copyRule'),
               icon: const Icon(Icons.copy_rounded, size: 18),
-              onSelected: (String text) => _copy(
-                context,
-                text,
-                isRule: text != value,
-              ),
+              onSelected: (String text) =>
+                  _copy(context, text, isRule: text != value),
               itemBuilder: (BuildContext context) => <PopupMenuEntry<String>>[
                 for (final ClashRuleCandidate candidate in candidates)
                   PopupMenuItem<String>(
@@ -304,11 +302,7 @@ class ConnectionDetailRow extends StatelessWidget {
     );
   }
 
-  static void _copy(
-    BuildContext context,
-    String text, {
-    required bool isRule,
-  }) {
+  static void _copy(BuildContext context, String text, {required bool isRule}) {
     final AikoL10n l10n = context.l10n;
     // Fire and forget: the platform side of setData cannot fail in a way the
     // user could act on, and blocking the menu dismissal on it would be worse.

mobile/lib/features/connections/connection_fields.dart

@@ -137,9 +137,7 @@ class ConnectionsFeedNotifier extends Notifier<ConnectionsFeedState> {
   }
 
   static List<ConnectionInfo> _trim(List<ConnectionInfo> items, int limit) =>
-      items.length > limit
-      ? items.sublist(items.length - limit)
-      : items;
+      items.length > limit ? items.sublist(items.length - limit) : items;
 
   /// Folds one `/connections` frame into the feed.
   ///
@@ -211,9 +209,7 @@ class ConnectionsFeedNotifier extends Notifier<ConnectionsFeedState> {
     if (state.paused == paused) return;
     state = state.copyWith(paused: paused);
     if (!paused) {
-      ref
-          .read(connectionsSnapshotProvider)
-          .whenOrNull<void>(data: ingest);
+      ref.read(connectionsSnapshotProvider).whenOrNull<void>(data: ingest);
     }
   }
 

mobile/lib/features/connections/connections_controller.dart

@@ -113,12 +113,7 @@ class _ConnectionsPageState extends ConsumerState<ConnectionsPage>
           mainAxisSize: MainAxisSize.min,
           children: <Widget>[
             Padding(
-              padding: const EdgeInsets.fromLTRB(
-                AikoDims.pagePadding,
-                0,
-                8,
-                8,
-              ),
+              padding: const EdgeInsets.fromLTRB(AikoDims.pagePadding, 0, 8, 8),
               child: Row(
                 children: <Widget>[
                   Expanded(
@@ -164,8 +159,8 @@ class _ConnectionsPageState extends ConsumerState<ConnectionsPage>
                     color: theme.colorScheme.error,
                     onPressed:
                         (_tab == ConnectionsTab.active
-                            ? visibleActive
-                            : visibleClosed)
+                                ? visibleActive
+                                : visibleClosed)
                             .isEmpty
                         ? null
                         : () => _closeVisible(
@@ -262,13 +257,13 @@ class _ConnectionsPageState extends ConsumerState<ConnectionsPage>
     if (!confirmed || !mounted) return;
 
     if (_tab == ConnectionsTab.closed) {
-      ref.read(connectionsFeedProvider.notifier).clearClosed(
-        ids: _query.isEmpty
-            ? null
-            : <String>{
-                for (final ConnectionInfo item in visible) item.id,
-              },
-      );
+      ref
+          .read(connectionsFeedProvider.notifier)
+          .clearClosed(
+            ids: _query.isEmpty
+                ? null
+                : <String>{for (final ConnectionInfo item in visible) item.id},
+          );
       return;
     }
 
@@ -356,9 +351,7 @@ class _TotalsBar extends StatelessWidget {
       ),
       child: Row(
         mainAxisAlignment: MainAxisAlignment.end,
-        children: <Widget>[
-          ConnectionTrafficPill(up: upload, down: download),
-        ],
+        children: <Widget>[ConnectionTrafficPill(up: upload, down: download)],
       ),
     );
   }
@@ -448,9 +441,7 @@ class _SortMenu extends ConsumerWidget {
       tooltip: l10n.t('connections.orderBy'),
       icon: const Icon(Icons.sort_rounded),
       onSelected: (String value) async {
-        final AppConfigNotifier notifier = ref.read(
-          appConfigProvider.notifier,
-        );
+        final AppConfigNotifier notifier = ref.read(appConfigProvider.notifier);
         final ScaffoldMessengerState? messenger = ScaffoldMessenger.maybeOf(
           context,
         );

mobile/lib/features/connections/connections_page.dart

@@ -57,7 +57,10 @@ TrafficAmount splitTraffic(int bytes) {
     value /= 1024;
     unit++;
   }
-  return (value: formatTrafficMagnitude(value), unitKey: kTrafficUnitKeys[unit]);
+  return (
+    value: formatTrafficMagnitude(value),
+    unitKey: kTrafficUnitKeys[unit],
+  );
 }
 
 /// `"1.20 MB"` — [splitTraffic] with its unit key resolved.

mobile/lib/features/connections/format.dart

@@ -160,8 +160,7 @@ final Provider<List<LogLine>> visibleLogsProvider = Provider<List<LogLine>>((
   final List<LogLine> out = <LogLine>[];
   for (int i = source.length - 1; i >= start; i--) {
     final LogLine line = source[i];
-    if (logPassesLevel(line, view.level) &&
-        logMatchesQuery(line, view.query)) {
+    if (logPassesLevel(line, view.level) && logMatchesQuery(line, view.query)) {
       out.add(line);
     }
   }

mobile/lib/features/logs/logs_controller.dart

@@ -240,9 +240,7 @@ class _LevelMenu extends ConsumerWidget {
       ),
       onSelected: (String value) => ref
           .read(logsViewProvider.notifier)
-          .setLevel(
-            value == _allValue ? null : LogLevel.fromWire(value),
-          ),
+          .setLevel(value == _allValue ? null : LogLevel.fromWire(value)),
       itemBuilder: (BuildContext context) => <PopupMenuEntry<String>>[
         CheckedPopupMenuItem<String>(
           value: _allValue,
@@ -324,9 +322,10 @@ class _LogsMenu extends StatelessWidget {
         PopupMenuItem<String>(
           enabled: false,
           child: Text(
-            l10n.t('logs.bufferHint', args: <String, Object?>{
-              'count': kLogsViewLineLimit,
-            }),
+            l10n.t(
+              'logs.bufferHint',
+              args: <String, Object?>{'count': kLogsViewLineLimit},
+            ),
             style: Theme.of(context).textTheme.bodySmall,
           ),
         ),

mobile/lib/features/logs/logs_page.dart

@@ -97,13 +97,13 @@ Map<String, dynamic> _asStringMap(Map<dynamic, dynamic> value) =>
       for (final entry in value.entries) entry.key.toString(): entry.value,
     };
 
-Map<String, dynamic> _cloneMap(Map<String, dynamic> value) =>
-    <String, dynamic>{
-      for (final entry in value.entries) entry.key: _cloneValue(entry.value),
-    };
+Map<String, dynamic> _cloneMap(Map<String, dynamic> value) => <String, dynamic>{
+  for (final entry in value.entries) entry.key: _cloneValue(entry.value),
+};
 
-List<dynamic> _cloneList(List<dynamic> value) =>
-    <dynamic>[for (final entry in value) _cloneValue(entry)];
+List<dynamic> _cloneList(List<dynamic> value) => <dynamic>[
+  for (final entry in value) _cloneValue(entry),
+];
 
 Object? _cloneValue(Object? value) {
   if (value is Map) return _cloneMap(_asStringMap(value));

mobile/lib/features/profiles/data/deep_merge.dart

@@ -37,7 +37,9 @@ class ProfileErrorText {
 /// [redactUrl]. Deliberately greedy about what counts as a URL — a false
 /// positive costs a redacted word, a false negative leaks a token.
 final RegExp _urlLike = RegExp(
-  r'[a-zA-Z][a-zA-Z0-9+.-]*://[^\s<>"' r"'" r']+',
+  r'[a-zA-Z][a-zA-Z0-9+.-]*://[^\s<>"'
+  r"'"
+  r']+',
 );
 
 /// Replaces every URL in [text] with its redacted form.
@@ -108,8 +110,8 @@ String describeBatchFailure(AikoL10n l10n, ProfileBatchFailure failure) {
     ProfileBatchFailureKind.notFound => l10n.t(
       'error.code.E_PROFILE_NOT_FOUND',
     ),
-    ProfileBatchFailureKind.network || ProfileBatchFailureKind.backoff => l10n
-        .t('error.code.E_SUBSCRIPTION_FETCH_FAILED'),
+    ProfileBatchFailureKind.network || ProfileBatchFailureKind.backoff =>
+      l10n.t('error.code.E_SUBSCRIPTION_FETCH_FAILED'),
     ProfileBatchFailureKind.invalidContent => l10n.t(
       'error.code.E_SUBSCRIPTION_INVALID',
     ),
@@ -133,8 +135,7 @@ String _subscriptionKey(SubscriptionErrorCode code) => switch (code) {
   SubscriptionErrorCode.htmlResponse ||
   SubscriptionErrorCode.emptyResponse ||
   SubscriptionErrorCode.unusableContent ||
-  SubscriptionErrorCode.outOfBounds =>
-    'error.code.E_SUBSCRIPTION_INVALID',
+  SubscriptionErrorCode.outOfBounds => 'error.code.E_SUBSCRIPTION_INVALID',
 };
 
 String _rawMessage(Object error) => switch (error) {