fix: sanitize deprecated npm_config env vars before deploy commands (#201)

## Problem

npm 10+ (shipped with Node 20.17+, Node 22+, Node 24) emits deprecation
warnings to stderr for legacy `npm_config_*` environment variables
inherited from the GitHub Actions runner environment:

```
npm warn config This environment variable is no longer supported: npm_config_version_tag_prefix
npm warn config This environment variable is no longer supported: npm_config_version_git_message
npm warn config This environment variable is no longer supported: npm_config_version_commit_hooks
```

Jarvis treats **any stderr output** as a deployment failure, causing
deploys to fail for repos that have upgraded to Node 24 (e.g. `results`
via #2436).

## Root Cause

These env vars are set by the runner environment (not by our workflows
or `.npmrc`). They are remnants of npm v6-era config that npm 10+ no
longer recognizes.

## Fix

Unset the deprecated keys before running deploy commands in both:
- `frontend-deploy-workflow.yml` (production deploy)
- `frontend-pr-workflow.yml` (preview deploy)

The `unset` is a no-op on older Node versions where these vars don't
exist, so this is safe for all repos regardless of Node version.

Author: kb-typeform

.github/workflows/frontend-deploy-workflow.yml

@@ -604,7 +604,17 @@ jobs:
           output_credentials: true
 
       - name: Deploy to production
-        run: ${{ inputs.deploy-command }}
+        run: |
+          # Remove deprecated npm config env vars inherited from the runner environment.
+          # npm 10+ (Node 20.17+/Node 22+) emits warnings to stderr for these legacy keys,
+          # and Jarvis treats any stderr output as a deployment failure.
+          # Using both UPPER and lower-case forms to cover all platforms.
+          unset NPM_CONFIG_ARGV NPM_CONFIG_VERSION_TAG_PREFIX NPM_CONFIG_VERSION_GIT_MESSAGE \
+                NPM_CONFIG_VERSION_COMMIT_HOOKS NPM_CONFIG__TYPEFORM_REGISTRY 2>/dev/null || true
+          unset npm_config_argv npm_config_version_tag_prefix npm_config_version_git_message \
+                npm_config_version_commit_hooks npm_config__typeform_registry 2>/dev/null || true
+
+          ${{ inputs.deploy-command }}
         env:
           # Jarvis debug logging
           DEBUG: jarvis

.github/workflows/frontend-pr-workflow.yml

@@ -520,7 +520,16 @@ jobs:
           account: 'prod'
 
       - name: Deploy preview
-        run: ${{ inputs.deploy-command }}
+        run: |
+          # Remove deprecated npm config env vars inherited from the runner environment.
+          # npm 10+ (Node 20.17+/Node 22+) emits warnings to stderr for these legacy keys,
+          # and Jarvis treats any stderr output as a deployment failure.
+          unset NPM_CONFIG_ARGV NPM_CONFIG_VERSION_TAG_PREFIX NPM_CONFIG_VERSION_GIT_MESSAGE \
+                NPM_CONFIG_VERSION_COMMIT_HOOKS NPM_CONFIG__TYPEFORM_REGISTRY 2>/dev/null || true
+          unset npm_config_argv npm_config_version_tag_prefix npm_config_version_git_message \
+                npm_config_version_commit_hooks npm_config__typeform_registry 2>/dev/null || true
+
+          ${{ inputs.deploy-command }}
         env:
           DEBUG: jarvis
           GH_TOKEN: ${{ secrets.GH_TOKEN }}