Skip to content

Commit a1d8edc

Browse files
Merge pull request #84 from Travelopia/feature/multi-select-unique-pills
Fix: Multi-Select - Allow unique pills incase of duplicate values
2 parents 1ff3267 + a22976d commit a1d8edc

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

src/multi-select/index.html

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
}
4747

4848
tp-multi-select-option + tp-multi-select-option {
49-
border-top: 1px solid #000;
49+
background-color: gainsboro;
5050
}
5151

5252
tp-multi-select-select-all[selected="yes"]::after,
@@ -97,14 +97,18 @@
9797
</tp-multi-select-search>
9898
</tp-multi-select-field>
9999
<tp-multi-select-options>
100-
<tp-multi-select-select-all select-text="Select All" unselect-text="Un-Select All">Select All</tp-multi-select-select-all>
101-
<tp-multi-select-option value="priya" label="Priya">Priya</tp-multi-select-option>
102-
<tp-multi-select-option value="varun" label="Varun">Varun</tp-multi-select-option>
103-
<tp-multi-select-option value="john" label="John">John</tp-multi-select-option>
104-
<tp-multi-select-option value="jane" label="Jane">Jane</tp-multi-select-option>
105-
<tp-multi-select-option value="jack" label="Jack">Jack</tp-multi-select-option>
106-
<tp-multi-select-option value="jill" label="Jill" disabled="yes">Jill</tp-multi-select-option>
107-
</tp-multi-select-options>
100+
<div>
101+
<div>Most Popular</div>
102+
<tp-multi-select-option value="Japan" label="Japan">Japan</tp-multi-select-option>
103+
<tp-multi-select-option value="Maldiverna" label="Maldiverna">Maldiverna</tp-multi-select-option>
104+
<tp-multi-select-option value="USA" label="USA">USA</tp-multi-select-option>
105+
</div>
106+
<div>
107+
<div>Asia</div>
108+
<tp-multi-select-option value="Japan" label="Japan">Japan</tp-multi-select-option>
109+
<tp-multi-select-option value="India" label="India">India</tp-multi-select-option>
110+
</div>
111+
</tp-multi-select-options>
108112
</tp-multi-select>
109113
</main>
110114
</body>

src/multi-select/tp-multi-select-pills.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export class TPMultiSelectPillsElement extends HTMLElement {
3939

4040
// Determine pills.
4141
const pills: NodeListOf<TPMultiSelectPillElement> | null = this.querySelectorAll( 'tp-multi-select-pill' );
42-
const values: string[] = multiSelect.value ?? [];
42+
const values: string[] = [ ...new Set( multiSelect.value ) ] ?? [];
4343
const pillValues: string[] = [];
4444

4545
// Remove pills that shouldn't exist.

0 commit comments

Comments
 (0)