Merge pull request #18 from Travelopia/fix/pills-update-with-setter

junaid-travelopia · web-flow · commit 35aba228674f · 2024-01-03T17:17:32.000+11:00
Fix `selected` attribute value in multi-select setter method
diff --git a/src/multi-select/tp-multi-select.ts b/src/multi-select/tp-multi-select.ts
@@ -89,7 +89,7 @@ export class TPMultiSelectElement extends HTMLElement {
 		const styledOptions: NodeListOf<TPMultiSelectOptionElement> | null = this.querySelectorAll( 'tp-multi-select-option' );
 		styledOptions?.forEach( ( option: TPMultiSelectOptionElement ): void => {
 			if ( value.includes( option.getAttribute( 'value' ) ?? '' ) ) {
-				option.setAttribute( 'selected', 'selected' );
+				option.setAttribute( 'selected', 'yes' );
 			} else {
 				option.removeAttribute( 'selected' );
 			}

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ export class TPMultiSelectElement extends HTMLElement {`
`89`	`89`	`const styledOptions: NodeListOf<TPMultiSelectOptionElement> \| null = this.querySelectorAll( 'tp-multi-select-option' );`
`90`	`90`	`styledOptions?.forEach( ( option: TPMultiSelectOptionElement ): void => {`
`91`	`91`	`if ( value.includes( option.getAttribute( 'value' ) ?? '' ) ) {`
`92`		`- option.setAttribute( 'selected', 'selected' );`
	`92`	`+ option.setAttribute( 'selected', 'yes' );`
`93`	`93`	`} else {`
`94`	`94`	`option.removeAttribute( 'selected' );`
`95`	`95`	`}`