Merge pull request #422 from TransactionProcessing/testing/#419_reviewdomainservicetests

Tests updated and added TxnValiationService

Author: StuartFerguson

TransactionProcessor.BusinessLogic.Tests/Services/SettlementDomainServiceTests.cs

@@ -41,7 +41,7 @@ public SettlementDomainServiceTests() {
         }
 
         [Fact]
-        public async Task TransactionDomainService_ProcessSettlement_SettlementIsProcessed()
+        public async Task SettlementDomainService_ProcessSettlement_SettlementIsProcessed()
         {
             settlementAggregateRepository.Setup(s => s.GetLatestVersion(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
                                          .ReturnsAsync(TestData.GetSettlementAggregateWithPendingMerchantFees(10));
@@ -59,7 +59,7 @@ public async Task TransactionDomainService_ProcessSettlement_SettlementIsProcess
         }
 
         [Fact]
-        public async Task TransactionDomainService_ProcessSettlement_SettlementAggregateNotCreated_NothingProcessed()
+        public async Task SettlementDomainService_ProcessSettlement_SettlementAggregateNotCreated_NothingProcessed()
         {
             settlementAggregateRepository.Setup(s => s.GetLatestVersion(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
                                          .ReturnsAsync(TestData.GetEmptySettlementAggregate);
@@ -75,7 +75,7 @@ public async Task TransactionDomainService_ProcessSettlement_SettlementAggregate
         }
 
         [Fact]
-        public async Task TransactionDomainService_ProcessSettlement_SettlementAggregateNoFeesToSettles_NothingProcessed()
+        public async Task SettlementDomainService_ProcessSettlement_SettlementAggregateNoFeesToSettles_NothingProcessed()
         {
             settlementAggregateRepository.Setup(s => s.GetLatestVersion(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
                                          .ReturnsAsync(TestData.GetCreatedSettlementAggregate);
@@ -91,7 +91,7 @@ public async Task TransactionDomainService_ProcessSettlement_SettlementAggregate
         }
 
         [Fact]
-        public async Task TransactionDomainService_ProcessSettlement_AddSettledFeeThrownException_SettlementProcessed()
+        public async Task SettlementDomainService_ProcessSettlement_AddSettledFeeThrownException_SettlementProcessed()
         {
             settlementAggregateRepository.Setup(s => s.GetLatestVersion(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
                                          .ReturnsAsync(TestData.GetSettlementAggregateWithPendingMerchantFees(10));

TransactionProcessor.BusinessLogic.Tests/Services/TransactionDomainServiceTests.cs

@@ -2,7 +2,7 @@
 
   <PropertyGroup>
 	  <TargetFramework>net7.0</TargetFramework>
-    <DebugType>None</DebugType>
+    <DebugType>Full</DebugType>
     <IsPackable>false</IsPackable>
   </PropertyGroup>
 

TransactionProcessor.BusinessLogic.Tests/Services/TransactionValidationServiceTests.cs

@@ -0,0 +1,30 @@
+namespace TransactionProcessor.BusinessLogic.Services;
+
+using System;
+using System.Threading;
+using System.Threading.Tasks;
+
+public interface ITransactionValidationService{
+    #region Methods
+
+    Task<(String responseMessage, TransactionResponseCode responseCode)> ValidateLogonTransaction(Guid estateId,
+                                                                                                  Guid merchantId,
+                                                                                                  String deviceIdentifier,
+                                                                                                  CancellationToken cancellationToken);
+
+    Task<(String responseMessage, TransactionResponseCode responseCode)> ValidateReconciliationTransaction(Guid estateId,
+                                                                                                           Guid merchantId,
+                                                                                                           String deviceIdentifier,
+                                                                                                           CancellationToken cancellationToken);
+
+    Task<(String responseMessage, TransactionResponseCode responseCode)> ValidateSaleTransaction(Guid estateId,
+                                                                                                 Guid merchantId,
+                                                                                                 Guid contractId,
+                                                                                                 Guid productId,
+                                                                                                 String deviceIdentifier,
+                                                                                                 String operatorIdentifier,
+                                                                                                 Decimal? transactionAmount,
+                                                                                                 CancellationToken cancellationToken);
+
+    #endregion
+}