Merge pull request #80 from StuartFerguson/task/#76_validatebalanceonsales

Minor fix after estate management change

Author: StuartFerguson

TransactionProcessor.BusinessLogic/Services/TransactionDomainService.cs

@@ -529,6 +529,8 @@ private async Task<TokenResponse> GetToken(CancellationToken cancellationToken)
                                                                                                    CancellationToken cancellationToken)
         {
             EstateResponse estate = null;
+            MerchantResponse merchant = null;
+
             // Validate the Estate Record is a valid estate
             try
             {
@@ -540,11 +542,11 @@ private async Task<TokenResponse> GetToken(CancellationToken cancellationToken)
             }
 
             // get the merchant record and validate the device
-            // TODO: Token
-            MerchantResponse merchant = await this.GetMerchant(estateId, merchantId, cancellationToken);
-
-            // TODO: Remove this once GetMerchant returns correct response when merchant not found
-            if (merchant.MerchantName == null)
+            try
+            {
+                merchant = await this.GetMerchant(estateId, merchantId, cancellationToken);
+            }
+            catch (Exception ex) when (ex.InnerException != null && ex.InnerException.GetType() == typeof(KeyNotFoundException))
             {
                 throw new TransactionValidationException($"Merchant Id [{merchantId}] is not a valid merchant for estate [{estate.EstateName}]",
                                                          TransactionResponseCode.InvalidMerchantId);

TransactionProcessor.IntegrationTests/Common/DockerHelper.cs

@@ -232,7 +232,8 @@ public override async Task StartContainersForScenarioRun(String scenarioName)
                                                                                                       (Setup.SqlServerContainerName,
                                                                                                       "sa",
                                                                                                       "thisisalongpassword123!"),
-                                                                                                      ("serviceClient", "Secret1"));
+                                                                                                      ("serviceClient", "Secret1"),
+                                                                                                      true);
 
             IContainerService securityServiceContainer = DockerHelper.SetupSecurityServiceContainer(this.SecurityServiceContainerName,
                                                                                                     this.Logger,