Skip to content

Conversation

@kasbah
Copy link
Member

@kasbah kasbah commented Nov 18, 2025

Deploy is now triggered by workflow_run of the build and thus will be run even on PRs from external contributors.

@kasbah kasbah marked this pull request as draft November 18, 2025 13:25
@kasbah kasbah force-pushed the kb/external-prs branch 4 times, most recently from b0f8bdd to 40049ad Compare November 18, 2025 14:25
Deploy is now triggered by `workflow_run` of the build and thus
will be run even on PRs from external contributors.
@jmoggr
Copy link
Collaborator

jmoggr commented Nov 19, 2025

  1. I'm very nervous about having other peoples code run in our CI, how certain are we that they can't exfiltrate secrets? For example could they open a PR with changes to our github actions which then run?

  2. This looks rather complicated and it seems that there is more going on then the PR title indicates. Github actions are a nightmare to debug, so I would lean towards keeping them as simple as possible.

@kasbah
Copy link
Member Author

kasbah commented Nov 20, 2025

Those are fair concerns @jmoggr.

    • As before, the running of any of our actions is dependant on manual approval for first-time PR creators. The new "deploy" workflow is triggered by running of the "build" workflow which needs the manual approval.
    • The "deploy" workflow is run in context of our main branch rather than the PR branch. A PRs modifying the "deploy" workflow does not affect any actions run until it is merged.
    • Coming to think of it, we can improve our security posture by making a "production" GH environment that always requires maintainer approval for access, no matter what.
  1. I don't disagree with keeping our CI as simple as possible but I do want these quality of life improvements such as the nicer inline deploy notifications (a big part of the complexity -- but this is already on main) and getting deploy previews for external contributions. Happy for any suggestions to simplify any of this.

@kasbah kasbah changed the title BUILD: Split build/deploy Github action workflows Split build/deploy allowing deploy from external PRs Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants