Skip to content

nullptr undeclared identifier when compiling using docker on github codespaces #2165

@githubawn

Description

@githubawn

Prerequisites

  • I have searched for similar issues and confirmed this is not a duplicate

Game Version

  • Command & Conquer Generals
  • Command & Conquer Generals: Zero Hour
  • Other (please specify below)

Bug Description

The Docker build fails when running in a fresh GitHub Codespace. The error C2065: 'nullptr' : undeclared identifier appears multiple times during compilation.

It seems the recent code updates #1938 introduced nullptr (C++11), which is not supported by the Visual Studio 6 compiler (cl.exe) used in the Docker container.

Expected behavior: The ./scripts/docker-build.sh script should complete successfully as described in the "Quick Start" documentation.

Reproduction Steps

Open https://github.com/TheSuperHackers/GeneralsGameCode
Press on <> Code
Press on Codespaces
Press on +
Wait till the vscode appears
Open terminal

type in: ./scripts/docker-build.sh

error log:
@githubawn ➜ workspacesGeneralsGame.txt

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    BuildAnything related to building, compilingCompileBugBug at compile timeMajorSeverity: Minor < Major < Critical < Blocker

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions