Skip to content

Conversation

@AlexeyBasinger
Copy link

Describe your change:

Refactor the red–black tree deletion logic in data_structures/binary_tree/red_black_tree.py to reduce cyclomatic complexity and improve readability while preserving the existing behavior
Main changes:

  1. Extracted the deletion logic from remove into small helper methods: _remove_node, _remove_with_two_children, _remove_with_zero_or_one_child, _remove_red_leaf, _remove_black_leaf, _remove_black_node_with_red_child
  2. Split _remove_repair into several case-specific helpers: _repair_red_sibling, _repair_black_parent_black_sibling_black_children, _repair_red_parent_black_sibling_black_children, _repair_inner_nephew, _repair_outer_nephew.
  3. Added null-safety checks (for example, around sibling usage) to avoid potential None access.
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@AlexeyBasinger AlexeyBasinger force-pushed the refactor-rb-tree-remove branch from 546e402 to b25fefb Compare December 1, 2025 20:34
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant