`only_once_review_widget` is monolingual

[nonprofittechy]

The words it prints should be run through at least the word() function

[nonprofittechy]

It might be better to use a template so that it can be translated in the normal translation spreadsheet though.

[BryceStevenWilley]

Few clarifying questions:

1. Assuming you're talking about review_widget, which is in this repo. only_once_review_widget is in GitHubFeedbForm and doesn't have any user-visible text (https://github.com/SuffolkLITLab/docassemble-GithubFeedbackForm/blob/a5e126a39b43b973645f0528aef3297af41793eb/docassemble/GithubFeedbackForm/data/questions/embedded_review.yml#L29-L39)
2. review_widget does use word()?

   docassemble-ALToolbox/docassemble/ALToolbox/misc.py

   Lines 275 to 298 in f719de0

   	<div class="card" style="width: 20rem;">
   	<div class="card-body">
   	<p class="al-thumbs-widget">{word(thumbs_display)}</p>
   	<a href="{js_thumbs_up}" id="al-thumbs-widget-up"
   	class="btn btn-md btn-info al-thumbs-widget" aria-label="{word('Thumbs up')}">{fa_icon('thumbs-up', size='md')}</a>
   	<a href="{js_thumbs_down}" id="al-thumbs-widget-down"
   	class="btn btn-md btn-info al-thumbs-widget" aria-label="{word('Thumbs down')}">{fa_icon('thumbs-down', size='md')}</a>
   	"""
   	if review_action:
   	review_area_id = review_action + "_area_id"
   	js_review = (
   	f"javascript:altoolbox_review_send('{review_action}', '{review_area_id}')"
   	)
   	widget += f"""
   	<p class="al-review-text al-hidden">{word(review_display)}</p>
   	<textarea class="datextarea al-review-text al-hidden" id="{review_area_id}"
   	alt="{word('Write your review here')}" rows="4"></textarea>
   	<br class="al-review-text">
   	{action_button_html(js_review, label=word(submit_review_button), size='md', classname='al-review-text al-hidden')}
   	"""
   	widget += f"""
   	<p class="al-after-review al-hidden">{word(post_review_display)}</p>
   	</div>
   	</div>"""

   Is the default param text in the server's translation stuff?

I like using templates when we can too, but that switch would be a bit tricky.

[nonprofittechy]

I think I wanted to mark the question and didn't look closely enough to spot the use of word(). But looking this over, it's kind of a nonstandard mix right now compared to the rest of our codebase:

• there are default string parameters
• the strings are then passed through word()

In other places we do have default string parameters where the word() command is used directly in the default value. And in other places, we have a default None value that triggers looking up a template.

I'm not sure the other way we do it is better, it's just different. With longer text like this, telling folks to edit the words.yml isn't usually the way I like to do it--especially as it's a server-wide configuration choice.