Upstream at pygithub - Replicate pygithub org secret deletion error

[plocket]

Deleting secrets seems to work for repos, but not orgs. Pygithub doesn't seem to have tests for deleting org secrets, though it looks like they used to have tests for deleting org secrets. Replicate so we can file an issue and possibly solve and make a PR.

The error:

Traceback (most recent call last):
  File "/usr/share/docassemble/local3.12/lib/python3.12/site-packages/flask/app.py", line 917, in full_dispatch_request
    rv = self.dispatch_request()
         ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/share/docassemble/local3.12/lib/python3.12/site-packages/flask/app.py", line 902, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)  # type: ignore[no-any-return]
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/share/docassemble/local3.12/lib/python3.12/site-packages/docassemble/webapp/server.py", line 8736, in index
    interview.assemble(user_dict, interview_status, old_user_dict, force_question=special_question)
  File "/usr/share/docassemble/local3.12/lib/python3.12/site-packages/docassemble/base/parse.py", line 9247, in assemble
    raise the_error
  File "/usr/share/docassemble/local3.12/lib/python3.12/site-packages/docassemble/base/parse.py", line 9034, in assemble
    question_result = self.askfor(missingVariable, user_dict, old_user_dict, interview_status, seeking=interview_status.seeking, follow_mc=follow_mc, seeking_question=seeking_question)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/share/docassemble/local3.12/lib/python3.12/site-packages/docassemble/base/parse.py", line 9747, in askfor
    exec_with_trap(question, user_dict)
  File "/usr/share/docassemble/local3.12/lib/python3.12/site-packages/docassemble/base/parse.py", line 10385, in exec_with_trap
    exec(the_question.compute, the_dict)
  File "<code block, docassemble.playground12ALKilnSetupd260628:main.yml, block on line 263>", line 7, in <module>
  File "/usr/share/docassemble/local3.12/lib/python3.12/site-packages/github/Secret.py", line 122, in delete
    self._requester.requestJsonAndCheck("DELETE", self.url)
                                                  ^^^^^^^^
  File "/usr/share/docassemble/local3.12/lib/python3.12/site-packages/github/Secret.py", line 111, in url
    self._url = self._makeStringAttribute(self.secrets_url + "/" + self.name)
                                          ^^^^^^^^^^^^^^^^
  File "/usr/share/docassemble/local3.12/lib/python3.12/site-packages/github/Secret.py", line 94, in secrets_url
    return self._secrets_url.value
           ^^^^^^^^^^^^^^^^^
AttributeError: 'OrganizationSecret' object has no attribute '_secrets_url'. Did you mean: 'secrets_url'?

The relevant code:

---
id: set secrets for internal tests
code: |
  # ...
  for secret in alkiln_internal_secrets:
    secret.delete()
  # ...
---
id: get secrets for internal tests
code: |
  _temp_secrets = []

  _org_secrets = []
  try:
    _org_secrets = list(showifdef('gh_org_holder', None).org.get_secrets())
  except Exception:
    pass
  
  _temp_secrets = [
    _org_secret for _org_secret in _org_secrets
    if _org_secret.name == 'SERVER_URL'
    or _org_secret.name == 'DOCASSEMBLE_DEVELOPER_API_KEY' ]

  _repo_secrets = []
  try:
    _repo_secrets = list(showifdef('gh_repo_holder', None ).repo.get_secrets())
  except Exception:
    pass

  _temp_secrets += [
    _repo_secret for _repo_secret in _repo_secrets
    if _repo_secret.name == 'SERVER_URL'
    or _repo_secret.name == 'DOCASSEMBLE_DEVELOPER_API_KEY' ]

  alkiln_internal_secrets = _temp_secrets