Misc documentation / log improvements

Found when working on the REST guide a while back.

Author: BryceStevenWilley

proxyserver/src/main/java/edu/suffolk/litlab/efsp/docassemble/FilingDocDocassembleJacksonDeserializer.java

@@ -150,9 +150,9 @@ public static Optional<FilingDoc> fromNode(
     if (node.has("tyler_merge_attachments")
         && node.get("tyler_merge_attachments").asBoolean(false)) {
       log.info(
-          _logName
-              + " indicated that we should only use the parent document; skipping parsing child"
-              + " elements");
+          "{} indicated that we should only use the parent document; skipping parsing child"
+              + " elements",
+          _logName);
     } else {
       if (node.has("elements") && node.get("elements").isArray()) {
         Iterable<JsonNode> nodes = node.get("elements")::elements;
@@ -179,10 +179,10 @@ public static Optional<FilingDoc> fromNode(
         NonEmptyList.<FilingAttachment>fromList(attachments);
     if (goodAttachments.isNone()) {
       log.warn(
-          "The "
-              + _logName
+          "The {}"
               + " document doesn't have sub documents / PDFs. It's possible that the document was"
-              + " turned off at runtime.");
+              + " turned off at runtime.",
+          _logName);
       return Optional.empty();
     }
     return Optional.of(

proxyserver/src/main/java/edu/suffolk/litlab/efsp/docassemble/FilingInformationDocassembleJacksonDeserializer.java

@@ -366,12 +366,10 @@ private static List<CaseServiceContact> extractServiceContacts(
             realId = Optional.of(PartyId.Already(partyAssoc.asText()));
           }
           log.info(
-              "Filing party id ("
-                  + partyAssoc.asText()
-                  + ") for service party assoc ("
-                  + servObj.get("contact_id").asText()
-                  + "): "
-                  + realId);
+              "Filing party id ({}) for service party assoc ({}): {}",
+              partyAssoc.asText(),
+              servObj.get("contact_id").asText(),
+              realId);
         } else if (partyAssoc != null && !partyAssoc.isNull()) {
           log.warn("What is party_association? should be text: {}", partyAssoc);
           collector.addWrong(

proxyserver/src/main/java/edu/suffolk/litlab/efsp/docassemble/PersonDocassembleJacksonDeserializer.java

@@ -123,7 +123,7 @@ public static Result<Person, FilingError> fromNode(JsonNode node, InfoCollector
         collector.addWrong(
             collector.requestVar(
                 "is_new",
-                "if the party is new to the the case",
+                "if the party is new to the case",
                 "bool",
                 List.of(),
                 Optional.of(isNew.toString())));

proxyserver/src/main/java/edu/suffolk/litlab/efsp/server/services/AuthenticationService.java

@@ -36,11 +36,12 @@ public AuthenticationService(SecurityHub security) {
    * @param loginInfo should be a JSON object, with the following keys:
    *     <ul>
    *       <li>api_key: the api key for this server
-   *       <li>tyler-myJurisdiction: an object ('myJurisdiction' can be any jurisdiction), with
-   *           these tyler jurisdiction values:
+   *       <li>tyler-myJurisdiction (e.g. tyler-illinois): an object ('myJurisdiction' can be any
+   *           jurisdiction), with these tyler jurisdiction values:
    *           <ul>
-   *             <li>username: Any tyler jurisdiction username. Example: 'illinois'
-   *             <li>password: The jurisdiction's password
+   *             <li>username: The username for a user in the given tyler jurisdiction. Example:
+   *                 'bob@example.com'
+   *             <li>password: The password for the given user.
    *           </ul>
    *     </ul>
    *     An example: <code>

proxyserver/src/main/java/edu/suffolk/litlab/efsp/server/setup/tyler/Ecf4Filer.java

@@ -243,7 +243,7 @@ private CoreMessageAndNames prepareFiling(
         if (maybeFilingCodes.stream().anyMatch(fc -> fc.isEmpty())) {
           InterviewVariable filingVar =
               collector.requestVar(
-                  "court_bundle[i].filing_type",
+                  "al_court_bundle[i].filing_type",
                   "What filing type is this?",
                   "text",
                   List.of(),