Update codes sanity checker

The check job now runs 7 mins after the codes refresh instead of 3hrs later. Moved the never-required-fields check out of TylerCodesParser and put it directly in CodesSanityChecker, and moved the knownCodeLookups list in there too. Stopped comparing against the interview's default code, since that's just a backup value and not what we actually expect the search to return - a single match is now treated as fine, nothing gets logged. Ambiguous matches now log a warning instead of an error.

Author: rajeswari1301

proxyserver/src/main/java/edu/suffolk/litlab/efsp/server/setup/tyler/TylerModuleSetup.java

@@ -243,18 +243,21 @@ public void preSetup() {
         scheduler.scheduleJob(
             buildJob("job-immediate-" + jurisdiction.getName()), immediateTrigger);
 
-        // Runs after the refresh job's immediate trigger above, so there's
-        // something in the codes db for it to check by the time it fires.
-        Trigger immediateCheckTrigger =
+        // Runs a few minutes after the refresh job, in its own group, so it checks
+        // against that day's freshly-updated codes without racing the refresh itself
+        String checkTriggerName = "check-trigger-" + jurisdiction.getName();
+        LocalTime checkTime = codesDbUpdateTime.plusMinutes(7);
+        Trigger checkTrigger =
             TriggerBuilder.newTrigger()
-                .withIdentity(
-                    "check-trigger-immediate-" + jurisdiction.getName(), "codes-check-group")
+                .withIdentity(checkTriggerName, "codes-check-group")
                 .startNow()
-                .withSchedule(SimpleScheduleBuilder.simpleSchedule().withIntervalInSeconds(40))
+                .withSchedule(
+                    CronScheduleBuilder.dailyAtHourAndMinute(
+                        checkTime.getHour(), checkTime.getMinute() + r.nextInt(4)))
                 .build();
-        log.info("Scheduling immediate codes sanity check job.");
-        scheduler.scheduleJob(
-            buildCheckJob("check-job-immediate-" + jurisdiction.getName()), immediateCheckTrigger);
+
+        log.info("Scheduling daily codes sanity check job around {}", checkTime);
+        scheduler.scheduleJob(buildCheckJob("check-job-" + jurisdiction.getName()), checkTrigger);
       }
     } catch (SchedulerException se) {
       log.error("Scheduler Exception: ", se);

proxyserver/src/main/java/edu/suffolk/litlab/efsp/tyler/ecfcodes/CodesSanityChecker.java

@@ -14,6 +14,32 @@ public class CodesSanityChecker {
 
   private static final Logger log = LoggerFactory.getLogger(CodesSanityChecker.class);
 
+  private static final List<String> neverRequiredFields =
+      List.of("PartyNameSuffix", "PartyMiddleName");
+
+  // Seed list, pulled from docassemble-MotionToStayEviction's efiling.yml. Add more as they come
+  // up.
+  private static final List<MaintainedCodeCheck> knownCodeLookups =
+      List.of(
+          new MaintainedCodeCheck(
+              "massachusetts",
+              "appeals:acsj",
+              MaintainedCodeCheck.CodeTable.CASE_CATEGORY,
+              List.of("Appeals Court Single Justice - Civil", "Civil"),
+              "https://github.com/SuffolkLITLab/docassemble-MotionToStayEviction/blob/"
+                  + "213bd40790525bb45fbc5b012c5649325c7e0bae/docassemble/MotionToStayEviction/"
+                  + "data/questions/efiling.yml#L33-L34",
+              null),
+          new MaintainedCodeCheck(
+              "massachusetts",
+              "appeals:acsj",
+              MaintainedCodeCheck.CodeTable.CASE_TYPE,
+              List.of("MAC Rule 6.0"),
+              "https://github.com/SuffolkLITLab/docassemble-MotionToStayEviction/blob/"
+                  + "213bd40790525bb45fbc5b012c5649325c7e0bae/docassemble/MotionToStayEviction/"
+                  + "data/questions/efiling.yml#L36-L38",
+              "8151"));
+
   private final CodeDatabase cd;
   private final String jurisdiction;
 
@@ -32,17 +58,20 @@ private void checkNeverRequiredFieldsForAllCourts() {
       if (courtCode.equals("1")) {
         continue;
       }
-      Optional<CourtLocationInfo> court = cd.getFullLocationInfo(courtCode);
-      if (court.isEmpty()) {
-        continue;
+      DataFields fields = cd.getDataFields(courtCode);
+      for (String fieldCode : neverRequiredFields) {
+        if (fields.getFieldRow(fieldCode).isrequired) {
+          log.error(
+              "Court {}: {} is marked required in datafieldconfig, which shouldn't happen",
+              courtCode,
+              fieldCode);
+        }
       }
-      TylerCodesParser parser = new TylerCodesParser(cd, null, court.get(), false);
-      parser.checkNeverRequiredFields();
     }
   }
 
   private void checkKnownCodeLookups() {
-    for (MaintainedCodeCheck check : KnownCodeLookups.ALL) {
+    for (MaintainedCodeCheck check : knownCodeLookups) {
       if (!check.jurisdiction().equals(jurisdiction)) {
         continue;
       }
@@ -79,36 +108,23 @@ private List<NameAndCode> fetchOptions(MaintainedCodeCheck check) {
   private void report(MaintainedCodeCheck check, CodeSearchMatcher.MatchResult result) {
     switch (result.type()) {
       case OK -> {
-        String actualCode = result.matches().get(0).getCode();
-        if (!actualCode.equals(check.expectedDefaultCode())) {
-          log.error(
-              "Court {} {}: filters {} now resolve to {}, but the interview at {} expects {}",
-              check.courtCode(),
-              check.table(),
-              check.filters(),
-              actualCode,
-              check.sourceInterviewUrl(),
-              check.expectedDefaultCode());
-        }
+        // A single match means the interview's search still resolves cleanly(nothing to report)
       }
       case NO_MATCH ->
           log.error(
-              "Court {} {}: filters {} matched nothing, but the interview at {} expects {}",
+              "Court {} {}: filters {} matched nothing. See {}",
               check.courtCode(),
               check.table(),
               check.filters(),
-              check.sourceInterviewUrl(),
-              check.expectedDefaultCode());
+              check.sourceInterviewUrl());
       case AMBIGUOUS ->
-          log.error(
-              "Court {} {}: filters {} matched more than one code ({}), but the interview at {}"
-                  + " expects {}",
+          log.warn(
+              "Court {} {}: filters {} matched more than one code ({}). See {}",
               check.courtCode(),
               check.table(),
               check.filters(),
               result.matches(),
-              check.sourceInterviewUrl(),
-              check.expectedDefaultCode());
+              check.sourceInterviewUrl());
     }
   }
 }

proxyserver/src/main/java/edu/suffolk/litlab/efsp/tyler/ecfcodes/KnownCodeLookups.java

@@ -2,14 +2,13 @@
 
 import java.util.List;
 
-// One entry in the hand-maintained list of interview code lookups.
-// Each entry mirrors a _filters/_default pair from a real interview's efiling.yml.
+// One entry in the hand-maintained list of interview code lookups. Each entry
+// mirrors a _filters list from a real interview's efiling.yml
 public record MaintainedCodeCheck(
     String jurisdiction,
     String courtCode,
     CodeTable table,
     List<String> filters,
-    String expectedDefaultCode,
     String sourceInterviewUrl,
     String caseCategoryCode) {
 

proxyserver/src/main/java/edu/suffolk/litlab/efsp/tyler/ecfcodes/MaintainedCodeCheck.java

@@ -186,28 +186,15 @@ public Result<FilingCode, CodeError> vetFilingType(
             });
   }
 
-  private static final List<String> neverRequiredFields =
-      List.of("PartyNameSuffix", "PartyMiddleName");
-
-  public List<String> checkNeverRequiredFields() {
-    List<String> offendingFields = new ArrayList<>();
-    for (String fieldCode : neverRequiredFields) {
-      DataFieldRow row = allDataFields.getFieldRow(fieldCode);
-      if (row.isrequired) {
-        log.error(
-            "DEV WARNING: Court {}: {} shouldn't ever be required, but this court has it set that way",
-            this.court.code,
-            fieldCode);
-        offendingFields.add(fieldCode);
-      }
-    }
-    return offendingFields;
-  }
-
   public Result<String, CodeError> vetSuffix(Optional<String> maybeSuffix) {
     DataFieldRow suffixRow = allDataFields.getFieldRow("PartyNameSuffix");
     if (suffixRow.isvisible) {
       List<NameAndCode> suffixes = cd.getNameSuffixes(this.court.code);
+      if ((maybeSuffix.isEmpty() || maybeSuffix.get().isBlank()) && suffixRow.isrequired) {
+        log.error(
+            "DEV WARNING: Court {}: WHY would you ever require a suffix? There aren't empty suffix codes at all.",
+            this.court.code);
+      }
       String suffix = maybeSuffix.orElse("");
       Optional<NameAndCode> suffixMatch =
           suffixes.stream().filter(s -> s.getName().equalsIgnoreCase(suffix)).findFirst();

proxyserver/src/main/java/edu/suffolk/litlab/efsp/tyler/ecfcodes/TylerCodesParser.java

@@ -470,29 +470,6 @@ public void testFilingComponents() {
     assertThat(resAgain).containsErr(new NoMatchingCode("333", List.of()));
   }
 
-  @Test
-  public void testCheckNeverRequiredFieldsNoneRequired() {
-    when(dataFields.getFieldRow("PartyNameSuffix"))
-        .thenReturn(
-            new DataFieldRow("1", "Suffix", true, false, "", "", "", "", "", "", false, "01"));
-    when(dataFields.getFieldRow("PartyMiddleName"))
-        .thenReturn(
-            new DataFieldRow("2", "Middle Name", true, false, "", "", "", "", "", "", false, "01"));
-    assertThat(((TylerCodesParser) parser).checkNeverRequiredFields()).isEmpty();
-  }
-
-  @Test
-  public void testCheckNeverRequiredFieldsSuffixRequired() {
-    when(dataFields.getFieldRow("PartyNameSuffix"))
-        .thenReturn(
-            new DataFieldRow("1", "Suffix", true, true, "", "", "", "", "", "", false, "01"));
-    when(dataFields.getFieldRow("PartyMiddleName"))
-        .thenReturn(
-            new DataFieldRow("2", "Middle Name", true, false, "", "", "", "", "", "", false, "01"));
-    assertThat(((TylerCodesParser) parser).checkNeverRequiredFields())
-        .containsExactly("PartyNameSuffix");
-  }
-
   DocumentTypeTableRow docType =
       new DocumentTypeTableRow("4444", null, filingCode.code, "false", null, null, null);
 

proxyserver/src/test/java/edu/suffolk/litlab/efsp/server/ecf4/tyler/TylerCodesParserTest.java

@@ -63,7 +63,7 @@ private void loadFromXmls() throws Exception {
     }
   }
 
-  // Illinois/adams doesn't have any KnownCodeLookups entries seeded (those are
+  // Illinois/adams doesn't have any code lookups entries seeded (those are
   // all MA's so far), so this mainly proves the whole pipeline runs
   // cleanly against a real Postgres schema without throwing.
   @Test