Skip to content

Reports: vars using secrets are handled poorly #1109

Description

@plocket

Potentially there's a hidden field involved. There might be a race condition with that hidden field. Even the report is just confusing - the information can be found. Not ideal, though. Of the reports, neither has 🤕 and the first of them is missing text saying anything about an error.

report.txt for a failure that was using a secret:

━━━━━━━━━━━━━━━
Scenario: G_n_Y org repo admin with only repo secrets
Tags: @gh_n_y @org_repo @happy @row8
━━━━━━━━━━━━━━━
I start the interview at "main.yml&alks_test=true"
  Trying to load the interview at "https://apps-dev.suffolklitlab.org/interview?new_session=1&i=docassemble.playground12ALKilnSetupd260628%3Amain.yml&alks_test=true"
  Successfully found the interview
the max seconds for each Step is 10
I set the var "environments['github_n_you']" to "True"
  screen id: environments
        | environments['github_n_you'] | True |  |
I tap to continue
I set the var "task_type" to "org_repo"
  screen id: gh-account-type
        | task_type | org_repo |  |
I set the var "wants_more_PAT_info" to "False"
        | wants_more_PAT_info | False |  |
I tap to continue
I set the var "installer.token" to the GitHub secret "ALKILN_ALKS_GH_ADMIN_ADMINORG_TOKEN"
        | installer.token | ALKILN_ALKS_GH_ADMIN_ADMINORG_TOKEN |  |

The scenario report.txt:

━━━━━━━━━━━━━━━
Scenario: G_n_Y org repo admin with only org secrets
Tags: @gh_n_y @org_repo @happy @row9
━━━━━━━━━━━━━━━
I start the interview at "main.yml&alks_test=true"
  Trying to load the interview at "https://apps-dev.suffolklitlab.org/interview?new_session=1&i=docassemble.playground12ALKilnSetupd260628%3Amain.yml&alks_test=true"
  Successfully found the interview
the max seconds for each Step is 10
I set the var "environments['github_n_you']" to "True"
  screen id: environments
        | environments['github_n_you'] | True |  |
I tap to continue
I set the var "task_type" to "org_repo"
  screen id: gh-account-type
        | task_type | org_repo |  |
I set the var "wants_more_PAT_info" to "False"
        | wants_more_PAT_info | False |  |
I tap to continue
I set the var "installer.token" to the GitHub secret "ALKILN_ALKS_GH_ADMIN_ADMINORG_TOKEN"
        | installer.token | ALKILN_ALKS_GH_ADMIN_ADMINORG_TOKEN |  |
For security, ALKiln will avoid creating a picture of the page for this error. It's possible a secret is being used on this screen.

**-- Scenario Failed --**

The cucumber error:

   ✔ And I tap to continue # ../var/www/.npm-global/lib/node_modules/@suffolklitlab/alkiln/lib/steps.js:823
   ✖ And I set the var "installer.token" to the GitHub secret "ALKILN_ALKS_GH_ADMIN_ADMINORG_TOKEN" # ../var/www/.npm-global/lib/node_modules/@suffolklitlab/alkiln/lib/steps.js:1086
       TypeError: Cannot set properties of null (setting 'value')
           at evaluate (evaluate at Object.setText (/var/www/.npm-global/lib/node_modules/@suffolklitlab/alkiln/lib/scope.js:2118:18), :0:26)
           at #evaluate (/var/www/.npm-global/lib/node_modules/@suffolklitlab/alkiln/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/ExecutionContext.js:386:56)
           at async ExecutionContext.evaluate (/var/www/.npm-global/lib/node_modules/@suffolklitlab/alkiln/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/ExecutionContext.js:273:16)
           at async IsolatedWorld.evaluate (/var/www/.npm-global/lib/node_modules/@suffolklitlab/alkiln/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/IsolatedWorld.js:99:16)
           at async CdpJSHandle.evaluate (/var/www/.npm-global/lib/node_modules/@suffolklitlab/alkiln/node_modules/puppeteer-core/lib/cjs/puppeteer/api/JSHandle.js:142:20)
           at async Object.setText (/var/www/.npm-global/lib/node_modules/@suffolklitlab/alkiln/lib/scope.js:2118:5)
           at async Object.input (/var/www/.npm-global/lib/node_modules/@suffolklitlab/alkiln/lib/scope.js:1943:9)
           at async Object.funnel_the_answer (/var/www/.npm-global/lib/node_modules/@suffolklitlab/alkiln/lib/scope.js:1778:24)
           at async Object.setVariable (/var/www/.npm-global/lib/node_modules/@suffolklitlab/alkiln/lib/scope.js:1698:20)
           at async Object.setFields (/var/www/.npm-global/lib/node_modules/@suffolklitlab/alkiln/lib/scope.js:2284:24)

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions