fix bootstrap tests

Author: Maximilian-Stefan-Ernst

src/frontend/fit/standard_errors/bootstrap.jl

@@ -19,7 +19,7 @@ Return bootstrap samples for `statistic`.
 - `n_boot`: number of boostrap samples
 - `data`: data to sample from. Only needed if different than the data from `sem_fit`
 - `specification`: a `ParameterTable` or `RAMMatrices` object passed to `replace_observed`.
-   Necessary for FIML models.
+   Necessary for FIML / WLS models.
 - `engine`: optimizer engine, passed to `fit`.
 - `parallel`: if `true`, run bootstrap samples in parallel on all available threads.
   The number of threads is controlled by the `JULIA_NUM_THREADS` environment variable or
@@ -143,7 +143,7 @@ Return bootstrap standard errors.
 - `n_boot`: number of boostrap samples
 - `data`: data to sample from. Only needed if different than the data from `sem_fit`
 - `specification`: a `ParameterTable` or `RAMMatrices` object passed to `replace_observed`.
-   Necessary for FIML models.
+   Necessary for FIML / WLS models.
 - `engine`: optimizer engine, passed to `fit`.
 - `parallel`: if `true`, run bootstrap samples in parallel on all available threads.
   The number of threads is controlled by the `JULIA_NUM_THREADS` environment variable or

test/examples/helper.jl

@@ -136,13 +136,13 @@ function test_estimates(
     end
 end
 
-function test_bootstrap(model_fit; n_boot = 500)
+function test_bootstrap(model_fit, spec; n_boot = 500)
     # hessian and bootstrap se are close
     se_he = se_hessian(model_fit)
-    se_bs = se_bootstrap(model_fit; n_boot = n_boot)
+    se_bs = se_bootstrap(model_fit; specification = spec, n_boot = n_boot)
     @test isapprox(se_bs, se_he, rtol = 0.2)
     # se_bootstrap and bootstrap |> se are close
-    bs_samples = bootstrap(model_fit; n_boot = n_boot)
+    bs_samples = bootstrap(model_fit; specification = spec, n_boot = n_boot)
     @test bs_samples[:n_converged] > 0.95*n_boot
     bs_samples = cat(bs_samples[:samples][BitVector(bs_samples[:converged])]..., dims = 2)
     se_bs_2 = sqrt.(var(bs_samples, corrected = false, dims = 2))

test/examples/multigroup/build_models.jl

@@ -83,7 +83,7 @@ end
         lav_col = :se,
         lav_groups = Dict(:Pasteur => 1, :Grant_White => 2),
     )
-    test_bootstrap(solution_ml)
+    test_bootstrap(solution_ml, partable)
     smoketest_CI_z(solution_ml, partable)
 
     solution_ml = fit(model_ml_multigroup2)
@@ -293,7 +293,7 @@ end
         lav_col = :se,
         lav_groups = Dict(:Pasteur => 1, :Grant_White => 2),
     )
-    test_bootstrap(solution_ls)
+    test_bootstrap(solution_ls, partable)
     smoketest_CI_z(solution_ls, partable)
 end
 
@@ -412,7 +412,7 @@ if !isnothing(specification_miss_g1)
             lav_col = :se,
             lav_groups = Dict(:Pasteur => 1, :Grant_White => 2),
         )
-        test_bootstrap(solution; n_boot = 500)
+        test_bootstrap(solution, partable_miss)
         smoketest_CI_z(solution, partable_miss)
 
         solution = fit(semoptimizer, model_ml_multigroup2)

test/examples/political_democracy/constructor.jl

@@ -131,7 +131,7 @@ end
         lav_col = :se,
     )
 
-    test_bootstrap(solution_ml)
+    test_bootstrap(solution_ml, partable)
     smoketest_CI_z(solution_ml, partable)
 end
 
@@ -161,7 +161,7 @@ end
         lav_col = :se,
     )
 
-    test_bootstrap(solution_ls)
+    test_bootstrap(solution_ls, partable)
     smoketest_CI_z(solution_ls, partable)
 end
 
@@ -344,7 +344,7 @@ end
         lav_col = :se,
     )
 
-    test_bootstrap(solution_ml)
+    test_bootstrap(solution_ml, partable_mean)
     smoketest_CI_z(solution_ml, partable_mean)
 end
 
@@ -373,7 +373,7 @@ end
         lav_col = :se,
     )
 
-    test_bootstrap(solution_ls)
+    test_bootstrap(solution_ls, partable_mean)
     smoketest_CI_z(solution_ls, partable_mean)
 end
 
@@ -507,6 +507,6 @@ end
         lav_col = :se,
     )
 
-    test_bootstrap(solution_ml)
+    test_bootstrap(solution_ml, partable_mean)
     smoketest_CI_z(solution_ml, partable_mean)
 end