Feedback

[MichaelPeter]

Hi you asked me for feedback for the library,

I will only be able to test it properly, here only the feedback I noticed so far with a quick look over:

First of all really nice, that you have explicit Blazor support and have written lots of tests.

• nuget package. You don't have a nuget package yet? That makes it harder to get started with the library or even find it.

• Windows Authentification: To use Windows Authentification/NTLM or MS-OFBA:
  I've seen you activate UseDefaultAuthentification by default that is nice. Maybe a example
  for Windows Authentification and MS-OFBA?
  https://www.webdavsystem.com/server/documentation/choosing_authentication/

• PropFind Instead of Propfind
  Since PROPFIND means Property Find I would have written PropFind. But I have no strong opinon on that, since both ways to write kinda look wrong.

• Async Postfixes:
  Again Personal Style, I write the async method names always with Async postfix but both sides have good arguments and I also experimented without the Async Postfix. (Especially if a class has async methods and non async methods)

• [NotNull] Arguments - again very nice that you use Nullable types, big fan! But why you used the [NonNull]-Attribute - are there issues with .NET Framework if you use the ? syntax? Or is that for legacy reasons?

• Everywhere Argument Validation I like that! Also the documenation for all methods.

• Idea: A way to call custom methods? Like to access the WebDav Dispatcher?
  Microsoft has some custom protcol extensions for web dav.
  But I mean I could create one and pass it in the constructor.

Greetings
Michael

[StefH]

@MichaelPeter Thanks for your review, see my comments below:

1. NuGet is available at https://www.nuget.org/packages/WebDAV-Client/

2. Windows Authentification --> I can indeed an example for this.

3. PropFind Instead of Propfind --> yes, maybe I can change this in next release, however not a big issue I think

4. Async Postfixes: --> Normally I used indeed the postfix, however for this project, which I forked, I did not change the interface. Maybe in the future.

5. [NotNull] Arguments --> This fork is older, and I did not spend time yest to fix this.

6. Idea: A way to call custom methods? --> I would not know yet how to implement this. Sorry.