Skip to content

Commit a458504

Browse files
committed
review fix
1 parent ff2f1ba commit a458504

1 file changed

Lines changed: 14 additions & 15 deletions

File tree

cmplibrary/src/main/java/com/sourcepoint/cmplibrary/SpConsentLibMobileCore.kt

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -77,16 +77,15 @@ class SpConsentLibMobileCore(
7777
private val spConsents: SPConsents get() = SPConsents(userData)
7878

7979
private var messageUI: SPMessageUI? = null
80-
get() {
81-
field = field ?: SPConsentWebView.create(
82-
context = context,
83-
messageUIClient = this@SpConsentLibMobileCore,
84-
propertyId = propertyId,
85-
onBackPressed = dismissMessageOnBackPress
86-
)
87-
return field!!
88-
}
89-
set(value) { field = value}
80+
fun getOrCreateMessageUI(): SPMessageUI {
81+
messageUI = messageUI ?: SPConsentWebView.create(
82+
context = context,
83+
messageUIClient = this@SpConsentLibMobileCore,
84+
propertyId = propertyId,
85+
onBackPressed = dismissMessageOnBackPress
86+
)
87+
return messageUI!!
88+
}
9089

9190
override fun loadMessage() = loadMessage(authId = null, pubData = null, cmpViewId = null)
9291

@@ -132,7 +131,7 @@ class SpConsentLibMobileCore(
132131
spClient.onSpFinished(spConsents)
133132
} else if (messagesToDisplay.isNotEmpty()) {
134133
val messageToRender = messagesToDisplay.removeFirst()
135-
messageUI!!.load(
134+
getOrCreateMessageUI().load(
136135
message = messageToRender.message,
137136
messageType = MessageType.fromMessageSubCategory(messageToRender.metaData.subCategoryId),
138137
url = messageToRender.url,
@@ -267,7 +266,7 @@ class SpConsentLibMobileCore(
267266
}
268267

269268
pendingActions++
270-
messageUI!!.load(
269+
getOrCreateMessageUI().load(
271270
messageType = messageType,
272271
url = buildPMUrl(
273272
campaignType = campaignType,
@@ -297,7 +296,7 @@ class SpConsentLibMobileCore(
297296
}
298297

299298
override fun dismissMessage() {
300-
messageUI!!.dismiss()
299+
getOrCreateMessageUI().dismiss()
301300
}
302301

303302
@Deprecated(message = "This method is deprecated and has no effect.")
@@ -353,7 +352,7 @@ class SpConsentLibMobileCore(
353352
finished(view)
354353
}
355354
ActionType.PM_DISMISS -> {
356-
if (messageUI!!.isFirstLayer) {
355+
if (getOrCreateMessageUI().isFirstLayer) {
357356
pendingActions--
358357
finished(view)
359358
}
@@ -391,7 +390,7 @@ class SpConsentLibMobileCore(
391390
}
392391

393392
override fun finished(view: View) {
394-
messageUI!!.isPresenting = false
393+
getOrCreateMessageUI().isPresenting = false
395394
runOnMain { spClient.onUIFinished(view) }
396395
renderNextMessageIfAny()
397396
}

0 commit comments

Comments
 (0)