Instance.OnPlayerLand does not detect all instances of player landing

[zer0k-z]

If the player lands while having positive vertical speed (ledgegrab), Instance.OnPlayerLand will not fire.

If the player climbs down a ladder and touch the ground, Instance.OnPlayerLand will not fire.

Alternatively, if timed perfectly, player can land on the ground via uncrouching while being exactly 9 to 11 units above a standable ground (crouchbug). Player takes no fall damage, does not lose stamina, and Instance.OnPlayerLand will also not fire.

[Poggicek]

does the game ever consider these as landings internally? (e.g. playing the landing sound), if not then I don't see this as a bug (in fact quite the opposite if this didn't match with the game's behavior), I would expect this to match with running GetGroundEntity every tick

[zer0k-z]

The landing sound logic is not the same as checking for the ground entity every tick. Checking for the ground every tick has its flaws as well; as you can land then leave the ground on the same tick, the per-tick ground check will never return true.

It also depends on whether you consider landing as having the ground entity changed or having the landing sound played (or checked at least, since you can land without sound by falling slower than the threshold).

I consider landing to be the former case, right now it behaves like the latter.

The implication of this is that if a mapper wants to measure how long a jump takes by comparing the time it takes from a player jump event to the next player land event, then that will not work in the scenarios described in the description.

[Poggicek]

Was there a change in the behavior? The description of the event was adjusted

[zer0k-z]

The behavior didn't change, but the description is now more or less correct (that depends on whether landing via unducking counts as "hit the ground while falling"). The function name might be a bit misleading now though, but I don't think there is a better name for it anyway (and it would break backwards compat).