Oscillators Audit

[korbexmachina]

Auditing the oscillator implementations for deviations from the SDK and User Guide.

• User Guide: Pages 39-42
• SDK

[MXCR-cpu]

User Guide Comparison Notes

• code implemented in the hal oscillator.rs complied with the user guide specification
• User guide was ambigious about IBRO -> INRO clock deferring

msdk Comparison Notes

• note: Default global scope system clock value in msdk, not in the hal

Enabling Clock

• Uses macros to control clock compile targets for particular targets
• Timeout case was handled in msdk; not hal -> assumes always successful execution else it hangs
  • msdk stores current clock to be restored in the event selected clock cannot be produced
  • note: No way to detect timeout in RISCV which alters clock timeout implementation for that case

Selecting Clock

• Oscillator enable and "set system clock" functions are not entangled logic in msdk; hal -> sel_sysclk() calls enable()

Disabling Clock

• msdk defines ClockDisable function; hal does not implement one

Sources

msdk