-
Notifications
You must be signed in to change notification settings - Fork 66
Description
I believe Shopify doesn't have a public repo for the GitHub App
( The one that syncs changes between GitHub <-> Shopify ) so I'm
posting it here.
I just tried using a push ruleset to prevent the
app from writing changes to the layout directory.
On GitHubs side that works as intended however the
sync process seems to break, as in that making any
change to any other file ( or in the customizer )
is not synced anymore.
Changes on GitHub still seem to be processed but the
Shopify -> GitHub sync is bricked afterwards and even
resetting to the latest commit doesn't fix it.
Only disconnecting the preview and reconnectinh it helps.
What it should do:
Not break, duh, either silently do nothing like it does
with everything else or you know, just show a failure to
write the file in the log - even better telling you that
it was because a rule prevented it.
For reproduction here is my ruleset:
Oh and maybe tell the website team to add an option to disable
sidekick & the code editor - as if that will ever happen.