Merge pull request #101 from Shopify/andyw8/fix-code-lens-heredoc-handling

Fix Code Lens heredoc handling

Author: andyw8

lib/ruby_lsp/ruby_lsp_rails/code_lens.rb

@@ -64,6 +64,9 @@ def on_command(node)
         # The test name may be a blank string while the code is being typed
         return if first_argument.parts.empty?
 
+        # We can't handle interpolation yet
+        return unless first_argument.parts.all? { |part| part.is_a?(SyntaxTree::TStringContent) }
+
         test_name = first_argument.parts.first.value
         return unless test_name
 

test/ruby_lsp_rails/code_lens_test.rb

@@ -56,6 +56,25 @@ class Test < ActiveSupport::TestCase
         assert_equal(3, response.size)
       end
 
+      test "ignores tests with interpolation in their names" do
+        # Note that we need to quote the heredoc RUBY marker to prevent interpolation when defining the test.
+        @store.set(uri: "file:///fake.rb", source: <<~'RUBY', version: 1)
+          class Test < ActiveSupport::TestCase
+            test "before #{1 + 1} after" do
+              # test body
+            end
+          end
+        RUBY
+
+        response = RubyLsp::Executor.new(@store, @message_queue).execute({
+          method: "textDocument/codeLens",
+          params: { textDocument: { uri: "file:///fake.rb" }, position: { line: 0, character: 0 } },
+        }).response
+
+        # The 3 responses are for the test class, none for the test declaration.
+        assert_equal(3, response.size)
+      end
+
       test "ignores tests with a non-string name argument" do
         @store.set(uri: "file:///fake.rb", source: <<~RUBY, version: 1)
           class Test < ActiveSupport::TestCase