Skip to content

Questions on implementation of dropping #39

@shuuchen

Description

@shuuchen

Hi,

I have some questions on the consistency of implementation of dropping and paper.

  1. When you take the sum, you did not use absolute values as written in the paper.

    di = wi.sum(0).sort()[1][self.count:self.count + delta]

  2. You drop during the stage, not when the stage finishes, as written in the paper.

    if not self._reach_stage(stage):

Am I wrong or would you explain about it ? Thank you.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions