-
Notifications
You must be signed in to change notification settings - Fork 130
Open
Description
Hi,
I have some questions on the consistency of implementation of dropping and paper.
-
When you take the sum, you did not use absolute values as written in the paper.
Line 86 in 833a91d
di = wi.sum(0).sort()[1][self.count:self.count + delta] -
You drop during the stage, not when the stage finishes, as written in the paper.
Line 62 in 833a91d
if not self._reach_stage(stage):
Am I wrong or would you explain about it ? Thank you.
Metadata
Metadata
Assignees
Labels
No labels