v2-rebase-main

[krisvanneste]

Claudio,

I tested the v2-rebase-main branch, and I encountered one issue and some minor ones:

• The main issue concerns the free_surface_amplification configuration parameter. If not set specifically, it defaults to ['2.0']. However, the _get_free_surface_amplification in ssp_build_spectra.py expects a scalar or a tuple of tuples. It thus raises an error, causing all spectra to be skipped. I think this is why you had to create an empty source_spec.conf in your notebook (marked as #FIXME)
• A minor issue is that an error occurs when trying to plot the stacked spectrum to screen, when config.options.outdir is set to None. This can be solved easily by replacing the last line in the plot_stacked_spectra function:

    _savefig(fig)

by

    if config.plot_show:
        plt.show()
    if config.plot_save:
        _savefig(fig)

similar to the other plotting functions

• Finally, I ran in some problems with my default python environment, which is still on python 3.7.10. This version does not support the := operator (used in config.py and config_helpers.py), nor the use of the |= operator with dictionaries (used in configobj.helpers.py. I realize I will have to update my environment eventually, but on the other hand I'm wondering if it is worth making sourcespec incompatible with all python versions before 3.9? Of course, this is your decision.

I also tested the feature to calculate travel times from a 1D velocity model, ported from v1, and it appears to work.

[claudiodsf]

Dear Kris,

Thanks for the feedback: I’ll try to address the raised points next week.

Just a quick note on Python support: Python 3.7 reached end of life in June 2023, and ObsPy 1.5.0 will require Python >= 3.8. I decided to drop support for 3.7 and 3.8 as a first step toward modernizing the codebase. These days it’s fairly straightforward to set up isolated environments using conda or uv, so hopefully this change won’t be too disruptive.