Fixes to Integration #75
Conversation
Joshua-Kloepfer
commented
Sep 30, 2025
Joshua-Kloepfer
commented
- Created test called testIntegrator to test triangles and tetrahedron with shape order one and two.
- Added documentation regarding the ordering of nodes required for integration.
- Corrected flawed values in integration points.
cwsmith
left a comment
cwsmith
left a comment
There was a problem hiding this comment.
Looks good. A few comments are below (as discussed offline).
If the self-hosted CI passes would you prefer to merge this or wait until we add the jacobian test on build-box/simmetrix sourced meshes? I'm fine either way.
docs/Ordering.tex
Outdated
| \filldraw[black] (2.5, 2.5) circle (2pt) node[anchor=south]{V2}; | ||
| \end{tikzpicture} | ||
| \\ | ||
| Any Counter clockwise ordering is fine ie: V0, V1, V2 and V2, V0, V1.\\ |
There was a problem hiding this comment.
I think we should remove the text describing what alternatives could work and just document the one that we currently use.
| \filldraw[black] (0, 2.5, 0) circle (2pt) node[anchor=south]{E5}; | ||
| \end{tikzpicture} | ||
| \\ | ||
| Vertex ordering must follow right hand rule and edge ordering must follow diagram. |
There was a problem hiding this comment.
I think we should keep this comment/text.
I think we should wait until we add further tests to make sure that everything is working before adding to main branch. |
| } | ||
|
|
||
| int main(int argc, char *argv[]) { | ||
| Mesh mesh = Mesh::MakeCartesian3D(100, 100, 100, Element::TETRAHEDRON, 100, 100, 100, false); |
There was a problem hiding this comment.
We should set the first three args from the command line so we can run a scaling test without having to recompile.
cwsmith
left a comment
cwsmith
left a comment
There was a problem hiding this comment.
As discussed offline, lets merge the two mfem integrator tests, drop the use of the 'star' mesh, and rely on the cartesian mesh (with user specified entity counts).
