refactor: extract the status visibility gate out of the presence service

Author: ricardogarim

ee/packages/presence/src/Presence.ts

@@ -1,14 +1,15 @@
 import { setTimeout, clearTimeout } from 'node:timers';
 
 import type { IPresence, IBrokerNode } from '@rocket.chat/core-services';
-import { License, ServiceClass, Settings, StatusVisibility } from '@rocket.chat/core-services';
+import { License, ServiceClass, Settings } from '@rocket.chat/core-services';
 import type { IUser } from '@rocket.chat/core-typings';
 import { UserStatus } from '@rocket.chat/core-typings';
 import { cronJobs } from '@rocket.chat/cron';
 import { Logger } from '@rocket.chat/logger';
 import { Users, UsersSessions } from '@rocket.chat/models';
 
 import { PresenceReaper } from './lib/PresenceReaper';
+import { STATUS_VISIBILITY_SETTING_ID, StatusVisibilityGate } from './lib/StatusVisibilityGate';
 import { normalizeStatusText } from './lib/normalizeStatusText';
 import { type ClaimUpdate, processPresence } from './lib/presenceEngine';
 
@@ -38,7 +39,7 @@ export class Presence extends ServiceClass implements IPresence {
 
 	private broadcastEnabled = true;
 
-	private statusVisibilityEnabled = false;
+	private statusVisibility = new StatusVisibilityGate();
 
 	private hasPresenceLicense = false;
 
@@ -65,8 +66,8 @@ export class Presence extends ServiceClass implements IPresence {
 			onUpdate: (userIds) => this.handleReaperUpdates(userIds),
 		});
 
-		this.onSettingChanged('Accounts_StatusVisibility_Enabled', async ({ setting }): Promise<void> => {
-			this.statusVisibilityEnabled = setting.value === true;
+		this.onSettingChanged(STATUS_VISIBILITY_SETTING_ID, async ({ setting }): Promise<void> => {
+			this.statusVisibility.setEnabled(setting.value);
 		});
 
 		this.onEvent('watch.instanceStatus', async ({ clientAction, id, diff }): Promise<void> => {
@@ -123,7 +124,7 @@ export class Presence extends ServiceClass implements IPresence {
 		try {
 			await Settings.set('Presence_broadcast_disabled', false);
 
-			this.statusVisibilityEnabled = (await Settings.get<boolean>('Accounts_StatusVisibility_Enabled')) === true;
+			await this.statusVisibility.start();
 			this.hasScalabilityLicense = await License.hasModule('scalability');
 			this.hasPresenceLicense = await License.hasModule('unlimited-presence');
 			this.hasLicense = this.hasPresenceLicense || this.hasScalabilityLicense;
@@ -428,16 +429,14 @@ export class Presence extends ServiceClass implements IPresence {
 			return;
 		}
 
-		if (this.statusVisibilityEnabled) {
-			void StatusVisibility.hasRestrictions(user._id)
-				.catch(() => true)
-				.then((hasVisibilityRestrictions) =>
-					this.api?.broadcast('presence.status', {
-						user,
-						previousStatus,
-						hasVisibilityRestrictions,
-					}),
-				);
+		if (this.statusVisibility.isEnabled()) {
+			void this.statusVisibility.hasRestrictions(user._id).then((hasVisibilityRestrictions) =>
+				this.api?.broadcast('presence.status', {
+					user,
+					previousStatus,
+					hasVisibilityRestrictions,
+				}),
+			);
 
 			return;
 		}

ee/packages/presence/src/lib/StatusVisibilityGate.ts

@@ -0,0 +1,24 @@
+import { Settings, StatusVisibility } from '@rocket.chat/core-services';
+import type { IUser } from '@rocket.chat/core-typings';
+
+export const STATUS_VISIBILITY_SETTING_ID = 'Accounts_StatusVisibility_Enabled';
+
+export class StatusVisibilityGate {
+	private enabled = false;
+
+	async start(): Promise<void> {
+		this.enabled = (await Settings.get<boolean>(STATUS_VISIBILITY_SETTING_ID)) === true;
+	}
+
+	setEnabled(value: unknown): void {
+		this.enabled = value === true;
+	}
+
+	isEnabled(): boolean {
+		return this.enabled;
+	}
+
+	async hasRestrictions(uid: IUser['_id']): Promise<boolean> {
+		return StatusVisibility.hasRestrictions(uid).catch(() => true);
+	}
+}