Skip to content

Fix hyperlinks not opening#69

Merged
Banane9 merged 1 commit into
masterfrom
fix/hyperlink-opening
Aug 24, 2025
Merged

Fix hyperlinks not opening#69
Banane9 merged 1 commit into
masterfrom
fix/hyperlink-opening

Conversation

@Banane9

@Banane9 Banane9 commented Aug 23, 2025

Copy link
Copy Markdown
Contributor

Fixes #68

@Banane9 Banane9 requested a review from Nytra August 23, 2025 17:56
@Banane9 Banane9 added the bug Something isn't working label Aug 23, 2025
@Nytra

Nytra commented Aug 23, 2025

Copy link
Copy Markdown
Contributor

Tested it?

@Banane9

Banane9 commented Aug 23, 2025

Copy link
Copy Markdown
Contributor Author

Yea - this is also how it's done in vanilla now, just minus the http(s) check

@Nytra

Nytra commented Aug 23, 2025

Copy link
Copy Markdown
Contributor

do you think it could allow code injection?

@Banane9

Banane9 commented Aug 24, 2025

Copy link
Copy Markdown
Contributor Author

It can still only do things in a protocol://something format, and users have to confirm opening it, so I don't see a risk there tbh. No different than using a browser and clicking some link tied to an application.

@Banane9 Banane9 merged commit e22c685 into master Aug 24, 2025
2 checks passed
@Banane9 Banane9 deleted the fix/hyperlink-opening branch August 24, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hyperlinks not opening

2 participants