Commit 9b3cd45
Fix WARP_SIZE detection for gfx942 in kernels.hip and ops.hip
Replace broken __GFX9__ guard with __AMDGCN_WAVEFRONT_SIZE
(compiler-provided) and default to 64 for CDNA. The __GFX9__ macro
is not defined at compile time on recent ROCm, causing WARP_SIZE=32
on 64-wide wavefront gfx942 (MI300X). This broke the 4-bit GEMV
inference kernel grid launch and warp reduction, producing ~50%
element mismatches in test_gemv_eye_4bit.
Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>1 parent 7c0057d commit 9b3cd45
2 files changed
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2853 | 2853 | | |
2854 | 2854 | | |
2855 | 2855 | | |
2856 | | - | |
2857 | | - | |
| 2856 | + | |
| 2857 | + | |
2858 | 2858 | | |
2859 | | - | |
| 2859 | + | |
2860 | 2860 | | |
2861 | 2861 | | |
2862 | 2862 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
| 23 | + | |
| 24 | + | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
0 commit comments