-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix: Use runtime session ID in /bug command #927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📋 Review SummaryThis PR fixes a bug in the 🔍 General Feedback
🎯 Specific Feedback🟢 Medium
🔵 Low
✅ Highlights
|
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
Fixed
/bugcommand to use the correct session ID from theConfiginstance instead of a static module-level UUID. The bug command was incorrectly importing a global staticsessionIdthat was generated once at module load time, rather than using the session-specific ID stored in eachConfiginstance.Dive Deeper
The Problem:
packages/core/src/utils/session.tsexports a staticsessionIdthat is generated once when the module loads:The
Configclass has its own instance-levelsessionIdthat is passed in during construction and stored per instance:The
/bugcommand was importing and using the static module-levelsessionId, which meant all bug reports would show the same ID regardless of which Config instance (session) was active.The Fix:
Changed the
/bugcommand to callconfig.getSessionId()to retrieve the instance-level session ID from the active Config object, ensuring each bug report contains the correct session ID for that specific session/Config instance.Testing Matrix
Testing performed:
This PR fixes a code logic bug where the
/bugcommand was using a static module-level session ID instead of the correct instance-level session ID from the Config object.