Skip to content

Conversation

@nisha617
Copy link
Collaborator

@nisha617 nisha617 commented Sep 9, 2025

This PR updates the translation in von_neumann_model.md.

Here are two issues:

  • ImportError
  • Regarding the definition, assumption, theorem and proof environments, change 'Definition', 'Assumption', 'Theorem' and 'Proof' to Chinese.

We can merge it once we fix them.

@netlify
Copy link

netlify bot commented Sep 9, 2025

Deploy Preview for astonishing-narwhal-a8fc64 ready!

Name Link
🔨 Latest commit 94e958d
🔍 Latest deploy log https://app.netlify.com/projects/astonishing-narwhal-a8fc64/deploys/68f5b52d43b68e000972b96a
😎 Deploy Preview https://deploy-preview-62--astonishing-narwhal-a8fc64.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Sep 9, 2025

@github-actions github-actions bot temporarily deployed to pull request September 9, 2025 12:29 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 10, 2025 14:55 Inactive
@mmcky mmcky requested a review from Copilot September 10, 2025 22:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Chinese translation of the von Neumann model documentation to improve consistency with the English version. The main purpose is to fix poorly-defined definition, assumption, and theorem environments that were inconsistent with the English version.

Key changes include:

  • Improved formatting and consistency of mathematical definitions, assumptions, and theorems using proper markup
  • Enhanced terminology consistency throughout the document
  • Minor text refinements for clarity and precision

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot temporarily deployed to pull request September 18, 2025 12:16 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 18, 2025 13:24 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 1, 2025 08:26 Inactive
@mmcky
Copy link
Contributor

mmcky commented Oct 2, 2025

Thanks @nisha617 the English language items in proof admonitions will be taken care of by executablebooks/sphinx-proof#152

@github-actions github-actions bot temporarily deployed to pull request October 20, 2025 03:24 Inactive
@mmcky
Copy link
Contributor

mmcky commented Oct 20, 2025

@nisha617 how does this look?

Screenshot 2025-10-20 at 2 25 17 pm

@github-actions github-actions bot temporarily deployed to pull request October 20, 2025 03:45 Inactive
@HumphreyYang
Copy link
Member

HumphreyYang commented Oct 20, 2025

Hi @mmcky,

This looks great to me!

Thanks so much!

@mmcky
Copy link
Contributor

mmcky commented Oct 20, 2025

thanks @HumphreyYang -- we now have a new release of sphinx-proof with support for 33 languages :-)

@HumphreyYang
Copy link
Member

That's so cool. I will click around to admire them in the preview!

@github-actions github-actions bot temporarily deployed to pull request October 20, 2025 04:17 Inactive
@nisha617
Copy link
Collaborator Author

Thanks @mmcky and @HumphreyYang! It looks super nice! Let me merge it now.

@nisha617 nisha617 merged commit 9a3ab21 into main Oct 22, 2025
6 checks passed
@nisha617 nisha617 deleted the von_neumann_model branch October 22, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants