Add error handling for ray cluster job_handler operations #1780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avilches
reviewed
Nov 26, 2025
Comment on lines
+41
to
+45
| "Job [%s] with ray_job_id [%s] failed to get status from Ray cluster. " | ||
| "Marking as FAILED. Error: %s", | ||
| job.id, | ||
| job.ray_job_id, | ||
| str(e), |
Contributor
There was a problem hiding this comment.
avilches
requested changes
Nov 26, 2025
Contributor
avilches
left a comment
avilches
left a comment
There was a problem hiding this comment.
Could you please add a test (unit, integration, whatever)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds error handling for Ray cluster operations in job status update command to prevent crashes when Ray operator loses job references.
Details and comments
This PR adds try-except blocks around Ray cluster API calls in
update_jobs_statuses.py:Status retrieval (line 35): Catches
RuntimeErrorwhen fetching job status. If error occurs, logs the issue and marks job as FAILED.Logs retrieval (line 76): Catches
RuntimeErrorwhen fetching job logs. If error occurs, logs a warning and continues execution without crashing.Impact: Prevents command crashes and provides better observability when Ray cluster loses track of jobs.