Refactor test fixtures to use valid authentication headers and remove unused community fixture

Author: Gildofj

tests/conftest.py

@@ -96,7 +96,7 @@ async def community(session: AsyncSession):
 
 
 @pytest_asyncio.fixture()
-async def token(async_client: AsyncGenerator[AsyncClient, None]) -> str:
+async def token(async_client: AsyncClient) -> str:
     form_data = {
         "grant_type": "password",
         "username": CommunityCredentials.username,

tests/test_libraries.py

@@ -1,7 +1,7 @@
 from datetime import date
+from typing import Mapping
 
 import pytest
-import pytest_asyncio
 from httpx import AsyncClient
 from sqlmodel import select
 from sqlmodel.ext.asyncio.session import AsyncSession
@@ -11,15 +11,6 @@
 from app.services.database.models import Community, Library
 
 
-@pytest_asyncio.fixture
-async def community(session: AsyncSession):
-    community = Community(username="admin", email="[email protected]", password="123")
-    session.add(community)
-    await session.commit()
-    await session.refresh(community)
-    return community
-
-
 @pytest.mark.asyncio
 async def test_insert_libraries(session: AsyncSession, community: Community):
     library = Library(
@@ -60,7 +51,9 @@ async def test_insert_libraries(session: AsyncSession, community: Community):
 
 @pytest.mark.asyncio
 async def test_post_libraries_endpoint(
-    async_client: AsyncClient, session: AsyncSession
+    session: AsyncSession,
+    async_client: AsyncClient,
+    valid_auth_headers: Mapping[str, str],
 ):
     body = {
         "library_name": "FastAPI",
@@ -79,7 +72,7 @@ async def test_post_libraries_endpoint(
     response = await async_client.post(
         "/api/libraries",
         json=body,
-        headers={"Content-Type": "application/json"},
+        headers=valid_auth_headers,
     )
 
     assert response.status_code == 200
@@ -104,7 +97,10 @@ async def test_post_libraries_endpoint(
 
 
 @pytest.mark.asyncio
-async def test_get_libraries_by_language(async_client: AsyncClient):
+async def test_get_libraries_by_language(
+    async_client: AsyncClient,
+    valid_auth_headers: Mapping[str, str],
+):
     body = {
         "library_name": "FastAPI",
         "news": [
@@ -122,7 +118,7 @@ async def test_get_libraries_by_language(async_client: AsyncClient):
     responsePOST = await async_client.post(
         "/api/libraries",
         json=body,
-        headers={"Content-Type": "application/json"},
+        headers=valid_auth_headers,
     )
 
     assert responsePOST.status_code == 200
@@ -131,6 +127,7 @@ async def test_get_libraries_by_language(async_client: AsyncClient):
     response = await async_client.get(
         "/api/libraries",
         params={"language": "Python"},
+        headers=valid_auth_headers,
     )
 
     assert response.status_code == 200
@@ -153,7 +150,10 @@ async def test_get_libraries_by_language(async_client: AsyncClient):
 
 
 @pytest.mark.asyncio
-async def test_get_libraries_by_inexistent_language(async_client: AsyncClient):
+async def test_get_libraries_by_inexistent_language(
+    async_client: AsyncClient,
+    valid_auth_headers: Mapping[str, str],
+):
     body = {
         "library_name": "FastAPI",
         "news": [
@@ -171,7 +171,7 @@ async def test_get_libraries_by_inexistent_language(async_client: AsyncClient):
     responsePOST = await async_client.post(
         "/api/libraries",
         json=body,
-        headers={"Content-Type": "application/json"},
+        headers=valid_auth_headers,
     )
 
     assert responsePOST.status_code == 200
@@ -180,6 +180,7 @@ async def test_get_libraries_by_inexistent_language(async_client: AsyncClient):
     response = await async_client.get(
         "/api/libraries",
         params={"language": "NodeJS"},
+        headers=valid_auth_headers,
     )
 
     assert response.status_code == 200

tests/test_libraries_request.py

@@ -1,21 +1,13 @@
+from typing import Mapping
+
 import pytest
-import pytest_asyncio
 from httpx import AsyncClient
 from sqlmodel import select
 from sqlmodel.ext.asyncio.session import AsyncSession
 
 from app.services.database.models import Community, LibraryRequest
 
 
-@pytest_asyncio.fixture
-async def community(session: AsyncSession):
-    community = Community(username="admin", email="[email protected]", password="123")
-    session.add(community)
-    await session.commit()
-    await session.refresh(community)
-    return community
-
-
 @pytest.mark.asyncio
 async def test_insert_libraries(session: AsyncSession, community: Community):
     library = LibraryRequest(
@@ -41,14 +33,17 @@ async def test_insert_libraries(session: AsyncSession, community: Community):
 
 @pytest.mark.asyncio
 async def test_post_libraries_endpoint(
-    async_client: AsyncClient, session: AsyncSession
+    async_client: AsyncClient,
+    session: AsyncSession,
+    community: Community,
+    valid_auth_headers: Mapping[str, str],
 ):
     body = {"library_name": "FastAPI", "library_home_page": "http://teste.com/"}
 
     response = await async_client.post(
         "/api/libraries/request",
         json=body,
-        headers={"Content-Type": "application/json", "user-email": "[email protected]"},
+        headers=valid_auth_headers,
     )
 
     assert response.status_code == 200
@@ -61,5 +56,5 @@ async def test_post_libraries_endpoint(
     created_request = result.first()
 
     assert created_request is not None
-    assert created_request.user_email == "[email protected]"
+    assert created_request.user_email == community.email
     assert created_request.library_home_page == "http://teste.com/"

tests/test_subscriptions.py

@@ -1,5 +1,6 @@
+from typing import Mapping
+
 import pytest
-import pytest_asyncio
 from httpx import AsyncClient
 from sqlmodel import select
 from sqlmodel.ext.asyncio.session import AsyncSession
@@ -8,15 +9,6 @@
 from app.services.database.models import Community, Subscription
 
 
-@pytest_asyncio.fixture
-async def community(session: AsyncSession):
-    community = Community(username="admin", email="[email protected]", password="123")
-    session.add(community)
-    await session.commit()
-    await session.refresh(community)
-    return community
-
-
 @pytest.mark.asyncio
 async def test_insert_subscription(session: AsyncSession, community: Community):
     subscription = Subscription(
@@ -45,7 +37,10 @@ async def test_insert_subscription(session: AsyncSession, community: Community):
     assert found.community_id == community.id
 
 
-async def preset_libraries_with_http_post(async_client: AsyncClient):
+async def preset_libraries_with_http_post(
+    async_client: AsyncClient,
+    valid_auth_headers: Mapping[str, str],
+):
     body1 = {
         "library_name": "Flask",
         "news": [
@@ -63,7 +58,7 @@ async def preset_libraries_with_http_post(async_client: AsyncClient):
     response1 = await async_client.post(
         "/api/libraries",
         json=body1,
-        headers={"Content-Type": "application/json"},
+        headers=valid_auth_headers,
     )
 
     assert response1.status_code == 200
@@ -85,17 +80,22 @@ async def preset_libraries_with_http_post(async_client: AsyncClient):
     response2 = await async_client.post(
         "/api/libraries",
         json=body2,
-        headers={"Content-Type": "application/json"},
+        headers=valid_auth_headers,
     )
 
     assert response2.status_code == 200
 
 
 @pytest.mark.asyncio
 async def test_post_subscribe_endpoint(
-    async_client: AsyncClient, session: AsyncSession
+    async_client: AsyncClient,
+    session: AsyncSession,
+    community: Community,
+    valid_auth_headers: Mapping[str, str],
 ):
-    await preset_libraries_with_http_post(async_client=async_client)
+    await preset_libraries_with_http_post(
+        async_client=async_client, valid_auth_headers=valid_auth_headers
+    )
 
     body = {
         "tags": ["bug_fix", "updates"],
@@ -105,13 +105,15 @@ async def test_post_subscribe_endpoint(
     response = await async_client.post(
         "/api/libraries/subscribe",
         json=body,
-        headers={"Content-Type": "application/json", "user-email": "[email protected]"},
+        headers=valid_auth_headers,
     )
 
     assert response.status_code == 200
     assert response.json()["status"] == "Subscribed in libraries successfully"
 
-    statement = select(Subscription).where(Subscription.user_email == "[email protected]")
+    statement = select(Subscription).where(
+        Subscription.user_email == community.email
+    )
     result = await session.exec(statement)
     created_subscriptions = result.all()
 
@@ -130,8 +132,11 @@ async def test_post_subscribe_endpoint(
 @pytest.mark.asyncio
 async def test_post_subscribe_endpoint_with_unexistents_libraries(
     async_client: AsyncClient,
+    valid_auth_headers: Mapping[str, str],
 ):
-    await preset_libraries_with_http_post(async_client=async_client)
+    await preset_libraries_with_http_post(
+        async_client=async_client, valid_auth_headers=valid_auth_headers
+    )
 
     body = {
         "tags": ["bug_fix", "updates"],
@@ -141,7 +146,7 @@ async def test_post_subscribe_endpoint_with_unexistents_libraries(
     response = await async_client.post(
         "/api/libraries/subscribe",
         json=body,
-        headers={"Content-Type": "application/json", "user-email": "[email protected]"},
+        headers=valid_auth_headers,
     )
 
     assert response.status_code == 404