Remove details from WriteSessionFailure

Which is currently unused. It must have been in use previously because the client is expecting specific reasons.

Since we need to redo this, let's remove the excess.

Author: andyleejordan

src/PowerShellEditorServices.Hosting/Configuration/SessionFileWriter.cs

@@ -20,8 +20,7 @@ public interface ISessionFileWriter
         /// Write a session file describing a failed startup.
         /// </summary>
         /// <param name="reason">The reason for the startup failure.</param>
-        /// <param name="details">Any details to accompany the reason.</param>
-        void WriteSessionFailure(string reason, object details);
+        void WriteSessionFailure(string reason);
 
         /// <summary>
         /// Write a session file describing a successful startup.
@@ -58,8 +57,7 @@ public SessionFileWriter(HostLogger logger, string sessionFilePath)
         /// Write a startup failure to the session file.
         /// </summary>
         /// <param name="reason">The reason for the startup failure.</param>
-        /// <param name="details">Any extra details, which will be serialized as JSON.</param>
-        public void WriteSessionFailure(string reason, object details)
+        public void WriteSessionFailure(string reason)
         {
             _logger.Log(PsesLogLevel.Diagnostic, "Writing session failure");
 
@@ -69,11 +67,6 @@ public void WriteSessionFailure(string reason, object details)
                 { "reason", reason },
             };
 
-            if (details != null)
-            {
-                sessionObject["details"] = details;
-            }
-
             WriteSessionObject(sessionObject);
         }