nix: replace statix with nixf-diagnose

The latter is the better static analyzer for Nix today.

Author: wolfgangwalther

default.nix

@@ -16,7 +16,7 @@ in
 , # Nix files that describe the Nixpkgs repository. We evaluate the expression
   # using `import` below.
   nixpkgs ? let inherit (nixpkgsVersion) owner repo rev tarballHash; in
-  builtins.fetchTarball {
+  fetchTarball {
     url = "https://github.com/${owner}/${repo}/archive/${rev}.tar.gz";
     sha256 = tarballHash;
   }
@@ -44,7 +44,7 @@ let
       inherit (lock.nodes.treefmt-nix) locked;
       inherit (locked) owner repo rev;
     in
-    builtins.fetchTarball {
+    fetchTarball {
       url = "https://github.com/${owner}/${repo}/archive/${rev}.tar.gz";
       sha256 = locked.narHash;
     };

nix/overlays/build-toolbox.nix

@@ -5,11 +5,11 @@
 , extra ? { }
 }:
 let
-  bash-completion = builtins.map (tool: (builtins.getAttr tool tools).bash-completion) (builtins.attrNames tools);
+  bash-completion = map (tool: (builtins.getAttr tool tools).bash-completion) (builtins.attrNames tools);
 
   env = buildEnv {
     inherit name;
-    paths = builtins.map (tool: (builtins.getAttr tool tools).bin) (builtins.attrNames tools);
+    paths = map (tool: (builtins.getAttr tool tools).bin) (builtins.attrNames tools);
   };
 
 in

nix/tools/withTools.nix

@@ -157,7 +157,7 @@ let
   withPgAll =
     let
       runners =
-        builtins.map
+        map
           (version:
             ''
               cat << EOF
@@ -333,7 +333,7 @@ buildToolbox
       withPgrst;
   } // builtins.listToAttrs (
     # Create a `postgrest-with-pg-` for each PostgreSQL version
-    builtins.map (pg: { inherit (pg) name; value = withTmpDb pg; }) postgresqlVersions
+    map (pg: { inherit (pg) name; value = withTmpDb pg; }) postgresqlVersions
   );
   # make latest withPg available for other nix files
   extra = { inherit withPg; };

nix/treefmt.nix

@@ -22,9 +22,9 @@ in
   programs.black.enable = true;
   programs.deadnix.enable = true;
   programs.hlint.enable = true;
+  programs.nixf-diagnose.enable = true;
   programs.nixpkgs-fmt.enable = true;
   programs.ruff-check.enable = true;
-  programs.statix.enable = true;
   programs.stylish-haskell.enable = true;
 
   settings.formatter.hlint.options = [

shell.nix

@@ -54,8 +54,8 @@ lib.overrideDerivation postgrest.env (
 
       ''
       + builtins.concatStringsSep "\n" (
-        builtins.map (bash-completion: "source ${bash-completion}") (
-          builtins.concatLists (builtins.map (toolbox: toolbox.bash-completion) toolboxes)
+        map (bash-completion: "source ${bash-completion}") (
+          builtins.concatLists (map (toolbox: toolbox.bash-completion) toolboxes)
         )
       );
   }