Skip to content

Conversation

@franciscoagx
Copy link

No description provided.

@franciscoagx franciscoagx changed the title prework frontend terminado Reto completado Aug 17, 2020
Copy link
Contributor

@teffcode teffcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing Job 🚀

Average:

  • HTML: 100%
  • CSS: 100%
  • JS: 100%

Things we can improve:

  • Be more consistent with the whitespaces between HTML Tags (Like line 57 of index.html)
  • Be more consistent with the classnames (HTML) and variable names (JS). For example, btn2 is the "Play again" button in HTML but btn2 is "player2_play" button in JS.
  • Be more consisten with the language on the code. I saw English (getGif) and Spanish (vida1, jugar...).
  • When I click on "Play again", the modal doesn't disappear 😥 I didn't see on the code something like: modal.style.visibility = "hidden".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants