Skip to content

Commit acf9e61

Browse files
author
Ralph Küpper
committed
docs(gc-handoff): correct the no-auto arm's description (warns, does not refuse)
1 parent 64177e0 commit acf9e61

1 file changed

Lines changed: 14 additions & 8 deletions

File tree

gc-handoff/REACTOR-NOTES.md

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -102,19 +102,25 @@ the check and the fix cannot drift apart. A CPU-only wrapper (bcrypt, argon2)
102102
never enters a tokio context, and requiring a shared compilation there would
103103
fail links that work.
104104

105-
**(b) Stop manufacturing the mismatch.**
106-
`build_missing_prebuilt_ext_lib` now refuses to build a tokio-using wrapper on
107-
its own under `PERRY_NO_AUTO_OPTIMIZE`, and says what to run instead. It cannot
108-
repair the situation itself: building the wrapper *with* `perry-stdlib-static`
109-
would fix tokio but silently overwrite the prebuilt stdlib with this
110-
invocation's feature set, dropping the `external-*-pump` features the no-auto
111-
flow needs — trading an abort for a hang.
105+
**(b) Warn where the mismatch is manufactured.**
106+
`build_missing_prebuilt_ext_lib` now says what it is about to do and why it
107+
usually ends badly, then builds anyway and lets (a) decide. It deliberately does
108+
**not** refuse: refusing there is a prediction, and two cargo invocations *can*
109+
unify to the same tokio — those links work, and a check that reads the actual
110+
archives should not fail them. (The first draft did refuse; it was softened
111+
after noticing it would fail `scripts/run_doc_tests.sh`-shaped builds that had
112+
never been shown to be broken.) It cannot repair the situation either: building
113+
the wrapper *with* `perry-stdlib-static` would fix tokio but silently overwrite
114+
the prebuilt stdlib with this invocation's feature set, dropping the
115+
`external-*-pump` features the no-auto flow needs — trading an abort for a hang.
112116

113117
**(c) Make the harness's own builds coherent.**
114118
`run_parity_tests.sh`: fold `-p perry-ext-net` into `BUILD_PACKAGES` instead of
115119
a second invocation, and under `PERRY_SKIP_BUILD=1` verify every required ext
116120
archive is present in `PERRY_RUNTIME_DIR` before running anything — with the
117-
exact command, instead of leaving the operator to decode six SIGABRTs.
121+
exact command, instead of leaving the operator to decode six SIGABRTs. (For the
122+
`all` suite that list is now empty by design: its ext-routed tests take the
123+
auto-optimize path per test, see (d), so no prebuilt ext archive is required.)
118124

119125
**(d) A second, independent defect the first one was hiding.**
120126
With coherent tokio the no-auto gap path still failed — now at *link*, with five

0 commit comments

Comments
 (0)