Compilation errors when updating to origin/main (0.13.0-dev69)

[rturrado]

I have just merged origin/main to a working branch, and I've found a couple of issues:

1. I had to export MLIR_DIR=~/Projects/catalyst/mlir/llvm-project/build/lib/cmake/mlir in order to compile the stablehlo project. Otherwise I was getting this error:

Building StableHLO as a standalone project.
-- The CXX compiler identification is Clang 18.1.3
-- The C compiler identification is Clang 18.1.3
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/clang - skipped
-- Detecting C compile features
-- Detecting C compile features - done
CMake Error at CMakeLists.txt:104 (find_package):
  Could not find a package configuration file provided by "MLIR" with any of                                                                                                                                                                                                                                    
  the following names:                                                                                                                                                                                                                                                                                          
                                                                                                                                                                                                                                                                                                                
    MLIRConfig.cmake                                                                                                                                                                                                                                                                                            
    mlir-config.cmake                                                                                                                                                                                                                                                                                           
                                                                                                                                                                                                                                                                                                                
  Add the installation prefix of "MLIR" to CMAKE_PREFIX_PATH or set                                                                                                                                                                                                                                             
  "MLIR_DIR" to a directory containing one of the above files.  If "MLIR"                                                                                                                                                                                                                                       
  provides a separate development package or SDK, be sure it has been                                                                                                                                                                                                                                           
  installed.

2. A make clean all from the catalyst root directory, using clang and clang++ still fails with the following error:

[110/116] Building CXX object lib/Quantum/Transforms/CMakeFiles/obj.quantum-transforms.dir/DecomposeLoweringPatterns.cpp.o
FAILED: lib/Quantum/Transforms/CMakeFiles/obj.quantum-transforms.dir/DecomposeLoweringPatterns.cpp.o 
/usr/bin/ccache /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/rturrado/Projects/catalyst/mlir/include -I/home/rturrado/Projects/catalyst/mlir/build/include -I/home/rturrado/Projects/catalyst/mlir/lib/Quantum/Transforms/. -I/home/rturrado/Projects/catalyst/mlir/stablehlo -I/home/rturrado/Projects/catalyst/mlir/stablehlo/build -isystem /home/rturrado/Projects/catalyst/mlir/llvm-project/llvm/include -isystem /home/rturrado/Projects/catalyst/mlir/llvm-project/build/include -isystem /home/rturrado/Projects/catalyst/mlir/llvm-project/mlir/include -isystem /home/rturrado/Projects/catalyst/mlir/llvm-project/build/tools/mlir/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=gnu++20   -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS  -fno-exceptions -funwind-tables -fno-rtti -Wall -UNDEBUG -Werror -MD -MT lib/Quantum/Transforms/CMakeFiles/obj.quantum-transforms.dir/DecomposeLoweringPatterns.cpp.o -MF lib/Quantum/Transforms/CMakeFiles/obj.quantum-transforms.dir/DecomposeLoweringPatterns.cpp.o.d -o lib/Quantum/Transforms/CMakeFiles/obj.quantum-transforms.dir/DecomposeLoweringPatterns.cpp.o -c /home/rturrado/Projects/catalyst/mlir/lib/Quantum/Transforms/DecomposeLoweringPatterns.cpp
/home/rturrado/Projects/catalyst/mlir/lib/Quantum/Transforms/DecomposeLoweringPatterns.cpp:86:11: error: missing field 'inWireIndices' initializer [-Werror,-Wmissing-field-initializers]
   86 |           })
      |           ^
1 error generated.

I don't see any differences in that part of the code with origin/main.

Does any of this issues ring a bell to you?

Many thanks!

[dime10]

Not sure what commit you started from, but did it involve an update to llvm and/or switch from mlir-hlo to stablehlo?

1. I think clearing the cmake cache / build directory might help? Obviously we'd like to avoid recompiling mlir unless we have to, but whenever we update the referenced upstream commit we do have to anyway (about once ~3 months currently).

2. I think the command you're looking for is make clean-all, the clean target only deletes the installed package as well as some other python-related cleanup, but it does not touch any compiled stuff in the mlir or runtime modules. I'm not sure about the specific error you're seeing, but maybe it will go away once all build directories are properly cleaned?

Thanks for sharing!

[rturrado]

Many thanks for your help @dime10!

It's working now. I understand that, somehow, my fork's head wasn't correctly updated.

This is a bit of an historic of my adventures:

• On an rturrado/catalyst checkout, both main and foo branches: clean all, delete the build folders, build... error.
• On an rturrado/catalyst-copy checkout (a fresh new one), main branch: build... error.
• On a PennyLaneAI/catalyst checkout (also a fresh new one), main branch: build... OK.
• Back on rturrado/catalyst-copy checkout, main branch: reset it to PennyLaneAI/catalyst's main branch, clean, build... OK.
• Git push that, check out the foo branch on that folder, and rebase it to my updated fork's remote main... OK.