support building against 2.8 too

Author: hobu

src/pdal/plang/Environment.hpp

@@ -54,9 +54,6 @@
 #define NPY_API_SYMBOL_ATTRIBUTE
 #define NPY_NO_DEPRECATED_API NPY_1_22_API_VERSION
 
-// PDAL renamed this but it is not aliased on windows for PDAL 2.9
-#   define PDAL_DLL     PDAL_EXPORT
-
 namespace pdal
 {
 namespace plang

src/pdal/plang/Invocation.hpp

@@ -42,9 +42,6 @@
 #include <pdal/Dimension.hpp>
 #include <pdal/PointView.hpp>
 
-// PDAL renamed this but it is not aliased on windows for PDAL 2.9
-#   define PDAL_DLL     PDAL_EXPORT
-
 namespace pdal
 {
 namespace plang

src/pdal/plang/Script.hpp

@@ -38,8 +38,10 @@
 
 #include <pdal/Options.hpp>
 
+#ifndef PDAL_DLL
 // PDAL renamed this but it is not aliased on windows for PDAL 2.9
 #   define PDAL_DLL     PDAL_EXPORT
+#endif
 
 namespace pdal
 {

src/pdal/test/PythonFilterTest.cpp

@@ -552,10 +552,12 @@ TEST_F(PredicateFilterTest, PredicateFilterTest_test_programmable_4)
     PointViewPtr buf(new PointView(table));
 
     filter->prepare(table);
+    reader.prepare(table);
+    PointViewSet viewSet = reader.execute(table);
 
-    StageWrapper::ready(reader, table);
-    PointViewSet viewSet = StageWrapper::run(reader, buf);
-    StageWrapper::done(reader, table);
+//     StageWrapper::ready(reader, table);
+//     PointViewSet viewSet = StageWrapper::run(reader, buf);
+//     StageWrapper::done(reader, table);
     EXPECT_EQ(viewSet.size(), 1u);
     buf = *viewSet.begin();
     EXPECT_EQ(buf->size(), 1000u);