-
Notifications
You must be signed in to change notification settings - Fork 80
Release 22.1.0 #2404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 22.1.0 #2404
Conversation
Summary of ChangesHello @Tobianas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request prepares the Lighty project for its 22.1.0 release. It systematically updates all Maven Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request prepares for the 22.1.0 release by updating the version from 22.1.0-SNAPSHOT to 22.1.0 across all pom.xml and documentation files. The changes are consistent and look correct for a release. I've found one minor issue in a README.md file where an incorrect artifact is referenced, and I've provided a suggestion to fix it. Otherwise, the changes are good to go.
| <dependency> | ||
| <groupId>io.lighty.core.parents</groupId> | ||
| <artifactId>lighty-dependency-artifacts</artifactId> | ||
| <version>22.1.0-SNAPSHOT</version> | ||
| <version>22.1.0</version> | ||
| <type>pom</type> | ||
| <scope>import</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The artifact io.lighty.core.parents:lighty-dependency-artifacts mentioned in this documentation snippet seems to be incorrect. This artifact does not appear to be defined within the project. Based on other pom.xml files, users should likely import a Bill of Materials (BOM) like io.lighty.core:lighty-bom to manage dependencies. Please update the documentation to reflect the correct artifact for users to import.
| <dependency> | |
| <groupId>io.lighty.core.parents</groupId> | |
| <artifactId>lighty-dependency-artifacts</artifactId> | |
| <version>22.1.0-SNAPSHOT</version> | |
| <version>22.1.0</version> | |
| <type>pom</type> | |
| <scope>import</scope> | |
| </dependency> | |
| <dependency> | |
| <groupId>io.lighty.core</groupId> | |
| <artifactId>lighty-bom</artifactId> | |
| <version>22.1.0</version> | |
| <type>pom</type> | |
| <scope>import</scope> | |
| </dependency> |
JIRA: LIGHTY-392 Signed-off-by: tobias.pobocik <[email protected]>
JIRA: LIGHTY-392 Signed-off-by: tobias.pobocik <[email protected]>
No description provided.